Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2847863005: [ObjC ARC] Converts ios/public/provider/chrome/browser/voice:voice to ARC. (Closed)

Created:
3 years, 7 months ago by stkhapugin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/public/provider/chrome/browser/voice:voice to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2847863005 Cr-Commit-Position: refs/heads/master@{#468659} Committed: https://chromium.googlesource.com/chromium/src/+/14f41de96dc519117571e6601e0859648b2e249b

Patch Set 1 #

Patch Set 2 : remove empty braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M ios/public/provider/chrome/browser/voice/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_language.mm View 1 2 chunks +4 lines, -7 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
stkhapugin
PTAL
3 years, 7 months ago (2017-05-02 13:51:55 UTC) #4
marq (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-02 14:10:17 UTC) #5
stkhapugin
Thank you!
3 years, 7 months ago (2017-05-02 14:14:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847863005/20001
3 years, 7 months ago (2017-05-02 14:14:54 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:07:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/14f41de96dc519117571e6601e08...

Powered by Google App Engine
This is Rietveld 408576698