Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2847863002: Enable gtk3 for 32-bit builds (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, inferno
CC:
chromium-reviews, Elliot Glaysher, inferno
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable gtk3 for 32-bit builds Now that [1] has been fixed and libgtk-3-0 has been installed in clusterfuzz's 32-bit configuration, it's safe to enable gtk3 for all platforms. [1] https://crbug.com/699669 BUG=79722 TBR=dpranke@chromium.org CC=erg@chromium.org,inferno@chromium.org Review-Url: https://codereview.chromium.org/2847863002 Cr-Commit-Position: refs/heads/master@{#468110} Committed: https://chromium.googlesource.com/chromium/src/+/94297f25fdf492db4eedd9524c413c7566994567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/config/linux/gtk/gtk.gni View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Tom (Use chromium acct)
dpranke@ ptal erg and inferno fyi
3 years, 7 months ago (2017-04-27 20:41:55 UTC) #1
inferno
lgtm
3 years, 7 months ago (2017-04-27 20:43:15 UTC) #4
Tom (Use chromium acct)
dpranke@ is OOO today so TBR'ing him
3 years, 7 months ago (2017-04-28 18:47:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847863002/1
3 years, 7 months ago (2017-04-28 18:49:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/94297f25fdf492db4eedd9524c413c7566994567
3 years, 7 months ago (2017-04-28 20:25:47 UTC) #11
Dirk Pranke
3 years, 7 months ago (2017-05-04 00:45:29 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698