Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2847813005: Prune ComputeVisibleSelectionInDOMTree from Editor::Cut/Copy/Paste (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
tkent, kojii
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTree from Editor::Cut/Copy/Paste This patch prunes some call sites of the deprecated function to improve code health. The change is safe because layout has been updated a few lines before each call site. BUG=698633 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2847813005 Cr-Commit-Position: refs/heads/master@{#468277} Committed: https://chromium.googlesource.com/chromium/src/+/e15ff1b5a013329a42aa8b8feb6d8d0faf16b0d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Xiaocheng
PTAL, as both yosin@ and tkent@ are OOO...
3 years, 7 months ago (2017-04-29 01:02:59 UTC) #7
kojii
tkent@, PTAL. Same here...
3 years, 7 months ago (2017-05-01 01:57:49 UTC) #9
tkent
lgtm. However, the CL description should explain why this change is safe.
3 years, 7 months ago (2017-05-01 02:24:14 UTC) #10
tkent
lgtm. However, the CL description should explain why this change is safe.
3 years, 7 months ago (2017-05-01 02:24:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847813005/1
3 years, 7 months ago (2017-05-01 02:30:18 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 04:10:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e15ff1b5a013329a42aa8b8feb6d...

Powered by Google App Engine
This is Rietveld 408576698