|
|
Created:
3 years, 7 months ago by Justin Donnelly Modified:
3 years, 7 months ago Reviewers:
Mark P CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpecify the trial name when crashing due to missing default group name.
BUG=716493
Review-Url: https://codereview.chromium.org/2847813004
Cr-Commit-Position: refs/heads/master@{#468112}
Committed: https://chromium.googlesource.com/chromium/src/+/8e5e44bc2a23a1599de02595e445257571f4f76f
Patch Set 1 #Patch Set 2 : Fix crash message. #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jdonnelly@chromium.org changed reviewers: + mpearson@chromium.org
Description was changed from ========== Specify the trial name when crashing due to missing default group name. BUG= ========== to ========== Specify the trial name when crashing due to missing default group name. BUG=716493 ==========
Apparently it's acceptable for a field trial to not specify a default_experiment_name so I need to update the message provided here.
lgtm
The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jdonnelly@chromium.org
The CQ bit was checked by jdonnelly@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2847813004/#ps40001 (title: "Fix crash message.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jdonnelly@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493409025763630, "parent_rev": "3d74f72c743bef9d6fb48d06b7638fdf0cb7c5aa", "commit_rev": "8e5e44bc2a23a1599de02595e445257571f4f76f"}
Message was sent while issue was closed.
Description was changed from ========== Specify the trial name when crashing due to missing default group name. BUG=716493 ========== to ========== Specify the trial name when crashing due to missing default group name. BUG=716493 Review-Url: https://codereview.chromium.org/2847813004 Cr-Commit-Position: refs/heads/master@{#468112} Committed: https://chromium.googlesource.com/chromium/src/+/8e5e44bc2a23a1599de02595e445... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8e5e44bc2a23a1599de02595e445... |