Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2847813004: Specify the trial name when crashing due to missing default group name. (Closed)

Created:
3 years, 7 months ago by Justin Donnelly
Modified:
3 years, 7 months ago
Reviewers:
Mark P
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify the trial name when crashing due to missing default group name. BUG=716493 Review-Url: https://codereview.chromium.org/2847813004 Cr-Commit-Position: refs/heads/master@{#468112} Committed: https://chromium.googlesource.com/chromium/src/+/8e5e44bc2a23a1599de02595e445257571f4f76f

Patch Set 1 #

Patch Set 2 : Fix crash message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/metrics/field_trial.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
Justin Donnelly
3 years, 7 months ago (2017-04-28 15:50:04 UTC) #5
Justin Donnelly
Apparently it's acceptable for a field trial to not specify a default_experiment_name so I need ...
3 years, 7 months ago (2017-04-28 16:23:11 UTC) #7
Mark P
lgtm
3 years, 7 months ago (2017-04-28 16:37:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847813004/40001
3 years, 7 months ago (2017-04-28 16:41:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/372923)
3 years, 7 months ago (2017-04-28 18:08:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847813004/40001
3 years, 7 months ago (2017-04-28 19:51:07 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:27:25 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8e5e44bc2a23a1599de02595e445...

Powered by Google App Engine
This is Rietveld 408576698