Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2438)

Issue 2847813003: [Web Payments] Fix alignment of certain Payment Sheet labels. (Closed)

Created:
3 years, 7 months ago by anthonyvd
Modified:
3 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Fix alignment of certain Payment Sheet labels. BUG=715086 Review-Url: https://codereview.chromium.org/2847813003 Cr-Commit-Position: refs/heads/master@{#467755} Committed: https://chromium.googlesource.com/chromium/src/+/8532d8f5c293c16f5a4677324a9c7d7bb71b837d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Apply the same treatment to the shipping option labels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
anthonyvd
Hi Math, PTAL!
3 years, 7 months ago (2017-04-27 18:01:45 UTC) #3
Mathieu
Are we sure we caught them all? https://codereview.chromium.org/2847813003/diff/1/chrome/browser/ui/views/payments/payment_request_views_util.cc File chrome/browser/ui/views/payments/payment_request_views_util.cc (right): https://codereview.chromium.org/2847813003/diff/1/chrome/browser/ui/views/payments/payment_request_views_util.cc#newcode83 chrome/browser/ui/views/payments/payment_request_views_util.cc:83: label->SetHorizontalAlignment(gfx::ALIGN_LEFT); bleh, ...
3 years, 7 months ago (2017-04-27 18:17:01 UTC) #5
Mathieu
lgtm
3 years, 7 months ago (2017-04-27 18:17:05 UTC) #6
anthonyvd
Was missing the shipping options label. Done now!
3 years, 7 months ago (2017-04-27 18:27:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847813003/20001
3 years, 7 months ago (2017-04-27 18:28:00 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:37:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8532d8f5c293c16f5a4677324a9c...

Powered by Google App Engine
This is Rietveld 408576698