[selectors4] :focus-within test when iframe loses focus

[selectors4] :focus-within test when iframe loses focus

This test should be part of https://codereview.chromium.org/2821303005
but at that time I didn't find the way to focus/unfocus an iframe.
The solution was to use internals.setFocused() for that purpose.

This patch adds a new test pretty similar to the one for windows
(fast/selectors/focus-within-window-inactive.html),
but checking what happens when an iframe loses and regains focus.

BUG=617371
TEST=fast/selectors/focus-within-iframe.html

Review-Url: https://codereview.chromium.org/2847803007
Cr-Commit-Position: refs/heads/master@{#468601}
Committed: https://chromium.googlesource.com/chromium/src/+/004ddc7b1a8b2c907f31179020ed17186b6639eb

[Manuel Rego, 2017-04-28 09:37:41]

rego@igalia.com changed reviewers:
+ rune@opera.com

[Manuel Rego, 2017-04-28 09:37:41]

We talked about this in the common ancestor patch,
and today I found how to focus/unfocus a frame.

If you think the inactive window test is enough
we can just close this CL without merging it.

[rune, 2017-04-28 13:00:03]

lgtm

https://codereview.chromium.org/2847803007/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/selectors/focus-within-iframe.html
(right):

https://codereview.chromium.org/2847803007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/selectors/focus-within-iframe.html:24:
frame.contentDocument.close();
You could probably just use the srcdoc attribute on the iframe element in the
markup directly instead of the write()?

[Manuel Rego, 2017-05-02 07:53:35]

Thanks for the review.

https://codereview.chromium.org/2847803007/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/selectors/focus-within-iframe.html
(right):

https://codereview.chromium.org/2847803007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/selectors/focus-within-iframe.html:24:
frame.contentDocument.close();
On 2017/04/28 13:00:03, rune wrote:
> You could probably just use the srcdoc attribute on the iframe element in the
> markup directly instead of the write()?

Done.

[Manuel Rego, 2017-05-02 07:53:42]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2017-05-02 07:53:43]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/2847803007/#ps20001
(title: "Use "srcdoc"")

[commit-bot: I haz the power, 2017-05-02 07:53:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 09:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 09:50:24]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Manuel Rego, 2017-05-02 09:59:11]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2017-05-02 09:59:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 11:40:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493719151061390,
"parent_rev": "e88c61071918fa4fb20bc803613160e1d6ac5081", "commit_rev":
"004ddc7b1a8b2c907f31179020ed17186b6639eb"}

[commit-bot: I haz the power, 2017-05-02 11:41:08]

Description was changed from

==========
[selectors4] :focus-within test when iframe loses focus

This test should be part of https://codereview.chromium.org/2821303005
but at that time I didn't find the way to focus/unfocus an iframe.
The solution was to use internals.setFocused() for that purpose.

This patch adds a new test pretty similar to the one for windows
(fast/selectors/focus-within-window-inactive.html),
but checking what happens when an iframe loses and regains focus.

BUG=617371
TEST=fast/selectors/focus-within-iframe.html
==========

to

==========
[selectors4] :focus-within test when iframe loses focus

This test should be part of https://codereview.chromium.org/2821303005
but at that time I didn't find the way to focus/unfocus an iframe.
The solution was to use internals.setFocused() for that purpose.

This patch adds a new test pretty similar to the one for windows
(fast/selectors/focus-within-window-inactive.html),
but checking what happens when an iframe loses and regains focus.

BUG=617371
TEST=fast/selectors/focus-within-iframe.html

Review-Url: https://codereview.chromium.org/2847803007
Cr-Commit-Position: refs/heads/master@{#468601}
Committed:
https://chromium.googlesource.com/chromium/src/+/004ddc7b1a8b2c907f31179020ed...
==========

[commit-bot: I haz the power, 2017-05-02 11:41:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/004ddc7b1a8b2c907f31179020ed...