Fix a crash bug on deallocation of CWVWebView caused by CWVScrollView.

Fix a crash bug on deallocation of CWVWebView caused by CWVScrollView.

Review-Url: https://codereview.chromium.org/2847803006
Cr-Commit-Position: refs/heads/master@{#469931}
Committed: https://chromium.googlesource.com/chromium/src/+/9499e291d08f34855a3c849f5b3e48ab62a9910b

[Hiroshi Ichikawa, 2017-04-28 05:01:17]

Description was changed from

==========
Fix a crash bug on deallocation of CWVWebView caused by CWVScrollView.

BUG=
==========

to

==========
Fix a crash bug on deallocation of CWVWebView caused by CWVScrollView.
==========

[Hiroshi Ichikawa, 2017-04-28 05:01:37]

ichikawa@chromium.org changed reviewers:
+ michaeldo@chromium.org

[Eugene But (OOO till 7-30), 2017-04-28 07:06:22]

eugenebut@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-04-28 07:06:23]

lgtm

https://codereview.chromium.org/2847803006/diff/1/ios/web_view/internal/cwv_s...
File ios/web_view/internal/cwv_scroll_view.mm (right):

https://codereview.chromium.org/2847803006/diff/1/ios/web_view/internal/cwv_s...
ios/web_view/internal/cwv_scroll_view.mm:74: self.proxy = nil;
_proxy = nil;

https://google.github.io/styleguide/objcguide.xml#Avoid_Accessors_During_init...

[Hiroshi Ichikawa, 2017-04-28 08:47:42]

https://codereview.chromium.org/2847803006/diff/1/ios/web_view/internal/cwv_s...
File ios/web_view/internal/cwv_scroll_view.mm (right):

https://codereview.chromium.org/2847803006/diff/1/ios/web_view/internal/cwv_s...
ios/web_view/internal/cwv_scroll_view.mm:74: self.proxy = nil;
On 2017/04/28 07:06:23, Eugene But wrote:
> _proxy = nil;
> 
>
https://google.github.io/styleguide/objcguide.xml#Avoid_Accessors_During_init...

The goal here is to call [_proxy removeObserver:self], so _proxy = nil doesn't
achieve the goal. I updated the code to call -removeObserver: directly.

[Eugene But (OOO till 7-30), 2017-04-28 10:08:57]

https://codereview.chromium.org/2847803006/diff/1/ios/web_view/internal/cwv_s...
File ios/web_view/internal/cwv_scroll_view.mm (right):

https://codereview.chromium.org/2847803006/diff/1/ios/web_view/internal/cwv_s...
ios/web_view/internal/cwv_scroll_view.mm:74: self.proxy = nil;
On 2017/04/28 08:47:41, Hiroshi Ichikawa wrote:
> On 2017/04/28 07:06:23, Eugene But wrote:
> > _proxy = nil;
> > 
> >
>
https://google.github.io/styleguide/objcguide.xml#Avoid_Accessors_During_init...
> 
> The goal here is to call [_proxy removeObserver:self], so _proxy = nil doesn't
> achieve the goal. I updated the code to call -removeObserver: directly.
Thanks!

[michaeldo, 2017-05-01 19:58:22]

lgtm

[Hiroshi Ichikawa, 2017-05-08 08:54:57]

The CQ bit was checked by ichikawa@chromium.org

[Hiroshi Ichikawa, 2017-05-08 08:54:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org, michaeldo@chromium.org
Link to the patchset: https://codereview.chromium.org/2847803006/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-05-08 08:55:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 09:06:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494233697673520,
"parent_rev": "8e987fe4730ac5991bb5091c449f7e0db81b60ea", "commit_rev":
"9499e291d08f34855a3c849f5b3e48ab62a9910b"}

[commit-bot: I haz the power, 2017-05-08 09:06:07]

Description was changed from

==========
Fix a crash bug on deallocation of CWVWebView caused by CWVScrollView.
==========

to

==========
Fix a crash bug on deallocation of CWVWebView caused by CWVScrollView.

Review-Url: https://codereview.chromium.org/2847803006
Cr-Commit-Position: refs/heads/master@{#469931}
Committed:
https://chromium.googlesource.com/chromium/src/+/9499e291d08f34855a3c849f5b3e...
==========

[commit-bot: I haz the power, 2017-05-08 09:06:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9499e291d08f34855a3c849f5b3e...