Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2847803005: Cleanup verifyKeyStatuses() to take KeyId/status pairs (Closed)

Created:
3 years, 7 months ago by jrummell
Modified:
3 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org, Srirama, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup verifyKeyStatuses() to take KeyId/status pairs As suggested in a previous CL, the status for each keyId should have it's own status value rather than relying on all the KeyIds to have the same status. No longer passing |unexpected|, as the size check verifies that the correct number of expected KeyIds matches. BUG=616166 TEST=modified tests pass Review-Url: https://codereview.chromium.org/2847803005 Cr-Commit-Position: refs/heads/master@{#468105} Committed: https://chromium.googlesource.com/chromium/src/+/42f79db5eabcab9856321dcbdec9953c156784a6

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
jrummell
PTAL
3 years, 7 months ago (2017-04-28 01:09:31 UTC) #3
xhwang
Nice cleanup! LGTM
3 years, 7 months ago (2017-04-28 16:23:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847803005/1
3 years, 7 months ago (2017-04-28 18:05:31 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:12:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42f79db5eabcab9856321dcbdec9...

Powered by Google App Engine
This is Rietveld 408576698