ExtensionNavigationThrottle: No platform apps in normal tabs.

extensions/browser/extension_navigation_throttle.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_navigation_throttle.h"
 
 #include "components/guest_view/browser/guest_view_base.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 #include "extensions/browser/url_request_util.h"
+#include "extensions/browser/view_type_utils.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/manifest_handlers/web_accessible_resources_info.h"
 #include "extensions/common/manifest_handlers/webview_info.h"
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "ui/base/page_transition_types.h"
 
 namespace extensions {
@@ skipping 74 matching lines @@
           &partition_domain, &partition_id, &in_memory);
 
       bool allowed = true;
       url_request_util::AllowCrossRendererResourceLoadHelper(
           is_guest, target_extension, owner_extension, partition_id, url.path(),
           navigation_handle()->GetPageTransition(), &allowed);
       if (!allowed)
         return content::NavigationThrottle::BLOCK_REQUEST;
     }
 
+    // Platform apps should only load in app windows, or guest views; never in
+    // regular tabs. TODO(nick): Further restrict the !guest case below.
+    if (target_extension->is_platform_app() && !guest) {
+      switch (GetViewType(web_contents)) {
+        case VIEW_TYPE_APP_WINDOW:
+        case VIEW_TYPE_BACKGROUND_CONTENTS:
+        case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
+        case VIEW_TYPE_PANEL:
+          break;
+        default:
+          return content::NavigationThrottle::CANCEL;
+      }
+    }
+
     return content::NavigationThrottle::PROCEED;
   }
 
   // This is a subframe navigation to a |target_extension| resource.
   // Enforce the web_accessible_resources restriction, and same-origin
   // restrictions for platform apps.
   content::RenderFrameHost* parent = navigation_handle()->GetParentFrame();
 
   // Look to see if all ancestors belong to |target_extension|. If not,
   // then the web_accessible_resource restriction applies.
@@ skipping 63 matching lines @@
     return CANCEL;
   }
   return result;
 }
 
 const char* ExtensionNavigationThrottle::GetNameForLogging() {
   return "ExtensionNavigationThrottle";
 }
 
 }  // namespace extensions