Exclude text processing items for insertions and passwords

Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression: it
unconditionally added the text processing menu items to the selection
menu. Originally these items were skipped in case isInsertion() or
isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090
Review-Url: https://codereview.chromium.org/2847793003
Cr-Commit-Position: refs/heads/master@{#467808}
Committed: https://chromium.googlesource.com/chromium/src/+/b8289814a679b6c85d497fba56e5e74c14ddee5b

[Tima Vaisburd, 2017-04-27 19:11:14]

Description was changed from

==========
Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression in that
it unconditinally added the text processing menu items to the
selection menu. Before these items were skipped when isIsertion()
or isElectionPassword() returns true.

This CL restores the old behavior.

BUG=714090
==========

to

==========
Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression:
it unconditionally added the text processing menu items to the
selection menu. Originally these items were skipped in case isInsertion()
or isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090
==========

[Tima Vaisburd, 2017-04-27 19:11:55]

Description was changed from

==========
Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression:
it unconditionally added the text processing menu items to the
selection menu. Originally these items were skipped in case isInsertion()
or isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090
==========

to

==========
Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression: it
unconditionally added the text processing menu items to the selection
menu. Originally these items were skipped in case isInsertion() or
isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090
==========

[Tima Vaisburd, 2017-04-27 19:12:23]

timav@chromium.org changed reviewers:
+ amaralp@chromium.org, boliu@chromium.org

[Tima Vaisburd, 2017-04-27 19:12:24]

PTAL.

[boliu, 2017-04-27 19:15:35]

lgtm

tests tests...

[Tima Vaisburd, 2017-04-27 21:04:59]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:05:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:43:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493327099641550, "parent_rev":
"fddf5df3d84f5c32e2dff8296b875b180afe9f02", "commit_rev":
"b8289814a679b6c85d497fba56e5e74c14ddee5b"}

[commit-bot: I haz the power, 2017-04-28 01:43:46]

Description was changed from

==========
Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression: it
unconditionally added the text processing menu items to the selection
menu. Originally these items were skipped in case isInsertion() or
isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090
==========

to

==========
Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression: it
unconditionally added the text processing menu items to the selection
menu. Originally these items were skipped in case isInsertion() or
isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090

Review-Url: https://codereview.chromium.org/2847793003
Cr-Commit-Position: refs/heads/master@{#467808}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8289814a679b6c85d497fba56e5...
==========

[commit-bot: I haz the power, 2017-04-28 01:43:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8289814a679b6c85d497fba56e5...