Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2847763003: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2847763003 Cr-Commit-Position: refs/heads/master@{#468004} Committed: https://chromium.googlesource.com/chromium/src/+/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f

Patch Set 1 #

Messages

Total messages: 15 (10 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-28 03:58:20 UTC) #4
vabr (Chromium)
LGTM, thanks for the improvement. Cheers, Vaclav
3 years, 7 months ago (2017-04-28 08:22:10 UTC) #8
Roger McFarlane (Google)
lgtm
3 years, 7 months ago (2017-04-28 14:58:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847763003/1
3 years, 7 months ago (2017-04-28 15:21:58 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 15:27:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ed8a8e75b505e27b8498ab83e82...

Powered by Google App Engine
This is Rietveld 408576698