Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2847743004: Revert of [Chromoting] Retrieve process resource usage (ProcessStats) and its tests (Closed)

Created:
3 years, 7 months ago by Qiang(Joe) Xu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Retrieve process resource usage (ProcessStats) and its tests (patchset #9 id:240001 of https://codereview.chromium.org/2775983003/ ) Reason for revert: Breaks x86-alex-tot-chrome-pfq-informational build: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/23688 Original issue's description: > [Chromoting] Retrieve process resource usage (ProcessStats) and its tests > > ProcessStatsStub is an interface to receive process resource usage information > from a ProcessStats. > > ProcessResourceUsage is a structure to store the resource usage of one process. > AggregatedProcessResourceUsage is a structure to store the resource usgaes of > several processes. > > ProcessStatsAgent is an interface to retrieve resource usage of one process. > CurrentProcessStatsAgent is a ProcessStatsAgent implementation to retrieve > resource usage from current process. > ForwardProcessStatsAgent receives resource usage from a third-party and forwards > the latest usage as a ProcessStatsAgent. > > ProcessStatsSender is a class to regularly report resource usages from various > ProcessStatsAgent implementations to a ProcessStatsStub. It merges several > non-empty ProcessResourceUsage into one AggregatedProcessResourceUsage. > This is typical useful on Windows: we need to calculate the resource usages from > both network process and desktop process. > > R=sergeyu@chromium.org, jamiewalch@chromium.org > BUG=650926 > > Review-Url: https://codereview.chromium.org/2775983003 > Cr-Commit-Position: refs/heads/master@{#467753} > Committed: https://chromium.googlesource.com/chromium/src/+/5928f440f84065ab45f848dcd135e3c2f52ca5bb TBR=jamiewalch@chromium.org,sergeyu@chromium.org,joedow@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650926 Review-Url: https://codereview.chromium.org/2847743004 Cr-Commit-Position: refs/heads/master@{#467786} Committed: https://chromium.googlesource.com/chromium/src/+/2b5a31c0dc8dcea1ae68da6b000c3622e68b4b9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -592 lines) Patch
M remoting/host/BUILD.gn View 4 chunks +0 lines, -10 lines 0 comments Download
D remoting/host/current_process_stats_agent.h View 1 chunk +0 lines, -36 lines 0 comments Download
D remoting/host/current_process_stats_agent.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D remoting/host/forward_process_stats_agent.h View 1 chunk +0 lines, -36 lines 0 comments Download
D remoting/host/forward_process_stats_agent.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D remoting/host/process_stats_agent.h View 1 chunk +0 lines, -26 lines 0 comments Download
D remoting/host/process_stats_sender.h View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/host/process_stats_sender.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D remoting/host/process_stats_sender_unittest.cc View 1 chunk +0 lines, -180 lines 0 comments Download
D remoting/host/process_stats_util.h View 1 chunk +0 lines, -24 lines 0 comments Download
D remoting/host/process_stats_util.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M remoting/proto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/proto/process_stats.proto View 1 chunk +0 lines, -47 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/protocol/process_stats_stub.h View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Qiang(Joe) Xu
Created Revert of [Chromoting] Retrieve process resource usage (ProcessStats) and its tests
3 years, 7 months ago (2017-04-27 20:50:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743004/1
3 years, 7 months ago (2017-04-27 20:50:55 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:52:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b5a31c0dc8dcea1ae68da6b000c...

Powered by Google App Engine
This is Rietveld 408576698