Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2847743003: Eliminate InterfaceRegistry (Closed)

Created:
3 years, 7 months ago by Ben Goodger (Google)
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate InterfaceRegistry: Last two usages in RFH: - media interface registry - java interface provider bridge both replaced by ad-hoc InterfaceProvider impls R=rockot@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2847743003 Cr-Commit-Position: refs/heads/master@{#468492} Committed: https://chromium.googlesource.com/chromium/src/+/8408b137e5dcdf9382350a20faab00ef441e7080

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Total comments: 4

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Patch Set 18 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -831 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +27 lines, -9 lines 0 comments Download
M content/browser/media/media_interface_proxy.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/media/media_interface_proxy.cc View 1 2 chunks +9 lines, -13 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +1 line, -2 lines 0 comments Download
M ios/web/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/fakes/test_web_state.mm View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/web_state.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +2 lines, -5 lines 0 comments Download
A ios/web/public/web_state/web_state_interface_provider.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +39 lines, -0 lines 0 comments Download
A ios/web/public/web_state/web_state_interface_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +26 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +3 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +6 lines, -6 lines 0 comments Download
M ios/web/webui/mojo_facade_unittest.mm View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +6 lines, -6 lines 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +3 lines, -2 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A media/mojo/services/media_interface_provider.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +38 lines, -0 lines 0 comments Download
A media/mojo/services/media_interface_provider.cc View 1 2 3 4 5 6 7 8 1 chunk +24 lines, -0 lines 0 comments Download
M media/mojo/services/media_service_unittest.cc View 1 2 chunks +3 lines, -8 lines 0 comments Download
M mojo/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D services/service_manager/public/cpp/interface_registry.h View 1 2 1 chunk +0 lines, -240 lines 0 comments Download
D services/service_manager/public/cpp/lib/interface_registry.cc View 1 2 1 chunk +0 lines, -267 lines 0 comments Download
D services/service_manager/public/cpp/tests/BUILD.gn View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D services/service_manager/public/cpp/tests/interface_registry_unittest.cc View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
M services/video_capture/service_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 3 4 1 chunk +0 lines, -32 lines 0 comments Download
M testing/buildbot/chromium.android.fyi.json View 1 2 3 4 2 chunks +0 lines, -27 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +0 lines, -76 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 97 (76 generated)
Ben Goodger (Google)
3 years, 7 months ago (2017-04-28 04:07:36 UTC) #18
Ken Rockot(use gerrit already)
Just a bunch of red from trivial compile/link errors. LGTM, woohoo! https://codereview.chromium.org/2847743003/diff/180001/ios/web/web_state/web_state_impl.h File ios/web/web_state/web_state_impl.h (right): ...
3 years, 7 months ago (2017-04-28 17:44:03 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/260001
3 years, 7 months ago (2017-04-28 20:47:54 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/200938) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-04-28 20:59:19 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/280001
3 years, 7 months ago (2017-04-28 21:41:09 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/200977) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-04-28 21:52:15 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/300001
3 years, 7 months ago (2017-04-28 21:53:36 UTC) #66
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/357615)
3 years, 7 months ago (2017-04-28 23:04:44 UTC) #68
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/300001
3 years, 7 months ago (2017-04-28 23:21:01 UTC) #70
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/357698)
3 years, 7 months ago (2017-04-29 00:01:31 UTC) #72
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/300001
3 years, 7 months ago (2017-04-29 00:03:04 UTC) #74
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/357726)
3 years, 7 months ago (2017-04-29 00:43:07 UTC) #76
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/300001
3 years, 7 months ago (2017-04-29 02:22:43 UTC) #78
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/357793)
3 years, 7 months ago (2017-04-29 02:59:22 UTC) #80
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/300001
3 years, 7 months ago (2017-04-29 15:09:41 UTC) #82
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/357848)
3 years, 7 months ago (2017-04-29 15:57:47 UTC) #84
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/300001
3 years, 7 months ago (2017-05-01 15:46:13 UTC) #86
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/320001
3 years, 7 months ago (2017-05-01 16:09:03 UTC) #89
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/433476)
3 years, 7 months ago (2017-05-01 20:54:53 UTC) #91
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847743003/340001
3 years, 7 months ago (2017-05-01 21:09:56 UTC) #94
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:49:09 UTC) #97
Message was sent while issue was closed. 
Committed patchset #18 (id:340001) as
https://chromium.googlesource.com/chromium/src/+/8408b137e5dcdf9382350a20faab...

Powered by Google App Engine
This is Rietveld 408576698