Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2847663004: vscode.md: change watcherExlude out/ to out*/ to filter ChromeOS build output (Closed)

Created:
3 years, 7 months ago by dullweber
Modified:
3 years, 7 months ago
Reviewers:
jdoerrie
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

vscode.md: change watcherExlude out/ to out*/ to filter ChromeOS build output BUG= Review-Url: https://codereview.chromium.org/2847663004 Cr-Commit-Position: refs/heads/master@{#467943} Committed: https://chromium.googlesource.com/chromium/src/+/48be158a96a8881a17517dd9d2f5f2c551c3dadf

Patch Set 1 #

Patch Set 2 : add some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M docs/vscode.md View 1 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
dullweber
approval please :)
3 years, 7 months ago (2017-04-28 09:12:01 UTC) #2
jdoerrie
lgtm
3 years, 7 months ago (2017-04-28 09:19:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847663004/1
3 years, 7 months ago (2017-04-28 09:20:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847663004/20001
3 years, 7 months ago (2017-04-28 09:28:51 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 09:40:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48be158a96a8881a17517dd9d2f5...

Powered by Google App Engine
This is Rietveld 408576698