Add callback to AndroidSyncSettings.updateAccount and fix related test

Add callback to AndroidSyncSettings.updateAccount and fix related test

AndroidSyncSettingsTest depends on implementation details of MockAccountManager
to wait for async method completion. These necessary details were removed
by 4a6245e626500c412e86e74e110542d33408e679. This CL fixes this test by
adding callback to AndroidSyncSettings.updateAccount.

BUG=605567
Review-Url: https://codereview.chromium.org/2847663003
Cr-Commit-Position: refs/heads/master@{#467785}
Committed: https://chromium.googlesource.com/chromium/src/+/f38bef32638791c40638f05cb48eb2041f71b7fe

[bsazonov, 2017-04-27 12:58:17]

bsazonov@chromium.org changed reviewers:
+ pavely@chromium.org

[bsazonov, 2017-04-27 12:58:18]

Pavel, please take a look.

[bsazonov, 2017-04-27 13:04:34]

Patchset #1 (id:1) has been deleted

[bsazonov, 2017-04-27 13:13:51]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 13:14:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 14:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 14:06:01]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[pavely, 2017-04-27 17:32:13]

lgtm % comment

https://codereview.chromium.org/2847663003/diff/20001/components/sync/android...
File
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java
(left):

https://codereview.chromium.org/2847663003/diff/20001/components/sync/android...
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java:160:
mAccountManager.waitForGetAccountsTask();
Could you remove waitForGetAccountsTask from MockAccountManager. I don't think
it is used anywhere else. Also without it MockAccountManager.ZeroCounter is not
used either.

[bsazonov, 2017-04-27 18:11:01]

https://codereview.chromium.org/2847663003/diff/20001/components/sync/android...
File
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java
(left):

https://codereview.chromium.org/2847663003/diff/20001/components/sync/android...
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java:160:
mAccountManager.waitForGetAccountsTask();
On 2017/04/27 17:32:12, pavely wrote:
> Could you remove waitForGetAccountsTask from MockAccountManager. I don't think
> it is used anywhere else. Also without it MockAccountManager.ZeroCounter is
not
> used either.

I will do that later, it you don't mind. I have some other refactoring work in
MockAccountManager going on right now. Thanks for the tip, though!

[pavely, 2017-04-27 18:13:36]

lgtm

[bsazonov, 2017-04-27 18:14:25]

The CQ bit was checked by bsazonov@chromium.org

[commit-bot: I haz the power, 2017-04-27 18:14:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:50:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493316865257610,
"parent_rev": "d0e6a4dc1cf50fbc387786abbb2379a2b2066aff", "commit_rev":
"f38bef32638791c40638f05cb48eb2041f71b7fe"}

[commit-bot: I haz the power, 2017-04-27 20:51:20]

Description was changed from

==========
Add callback to AndroidSyncSettings.updateAccount and fix related test

AndroidSyncSettingsTest depends on implementation details of MockAccountManager
to wait for async method completion. These necessary details were removed
by 4a6245e626500c412e86e74e110542d33408e679. This CL fixes this test by
adding callback to AndroidSyncSettings.updateAccount.

BUG=605567
==========

to

==========
Add callback to AndroidSyncSettings.updateAccount and fix related test

AndroidSyncSettingsTest depends on implementation details of MockAccountManager
to wait for async method completion. These necessary details were removed
by 4a6245e626500c412e86e74e110542d33408e679. This CL fixes this test by
adding callback to AndroidSyncSettings.updateAccount.

BUG=605567

Review-Url: https://codereview.chromium.org/2847663003
Cr-Commit-Position: refs/heads/master@{#467785}
Committed:
https://chromium.googlesource.com/chromium/src/+/f38bef32638791c40638f05cb48e...
==========

[commit-bot: I haz the power, 2017-04-27 20:51:21]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f38bef32638791c40638f05cb48e...