Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2847663002: Don't show touch handles when selection hidden (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/LayoutSelection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 6f3db2e977c3e9f30d4fc23ea5b43527f05c67d4..e97b0c3745f0bd2dc110a5c7467c9b042d5292d4 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2063,7 +2063,8 @@ bool FrameView::ComputeCompositedSelection(LocalFrame& frame,
const VisibleSelection& visible_selection =
frame.Selection().ComputeVisibleSelectionInDOMTree();
- if (visible_selection.IsNone() || !frame.Selection().IsHandleVisible())
+ if (visible_selection.IsNone() || !frame.Selection().IsHandleVisible() ||
+ frame.Selection().LayoutSelectionForceHide())
hugoh_UTC2 2017/04/27 08:53:50 Thanks a lot! I am rewriting the "hide selection"
yosin_UTC9 2017/04/27 09:55:11 Yes, let's use |FrameSelection::HasFocus()| hugoh@
hugoh_UTC2 2017/05/15 15:33:58 FrameSelection::SelectionHasFocus() and FrameSelec
return false;
// Non-editable caret selections lack any kind of UI affordance, and
« no previous file with comments | « third_party/WebKit/Source/core/editing/LayoutSelection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698