Don't show touch handles when selection hidden

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2045 matching lines @@
   }
 }
 
 bool FrameView::ComputeCompositedSelection(LocalFrame& frame,
                                            CompositedSelection& selection) {
   if (!frame.View() || frame.View()->ShouldThrottleRendering())
     return false;
 
   const VisibleSelection& visible_selection =
       frame.Selection().ComputeVisibleSelectionInDOMTree();
-  if (visible_selection.IsNone() || !frame.Selection().IsHandleVisible())
+  if (visible_selection.IsNone() || !frame.Selection().IsHandleVisible() ||
+      frame.Selection().LayoutSelectionForceHide())

[hugoh_UTC2, 2017/04/27 08:53:50]

Thanks a lot! I am rewriting the "hide selection" code right now in
https://codereview.chromium.org/2841093002 . In PS2 I expose a "HasFocus()" that
I think you can use instead of introducing LayoutSelectionForceHide().

[yosin_UTC9, 2017/04/27 09:55:11]

Yes, let's use |FrameSelection::HasFocus()| hugoh@ is introducing.

|LayoutSelectionForceHide()| doesn't represent selection state (has focus or not
focus) correctly.
At this time, we show selection for contenteditable regardless focus.

[hugoh_UTC2, 2017/05/15 15:33:58]

FrameSelection::SelectionHasFocus() and FrameSelection::IsHidden() have landed
and they can hopefully unblock this CL.

BTW, when using them, doesn't !visible_selection.IsNone() become redundant?

     return false;
 
   // Non-editable caret selections lack any kind of UI affordance, and
   // needn't be tracked by the client.
   if (visible_selection.IsCaret() && !visible_selection.IsContentEditable())
     return false;
 
   VisiblePosition visible_start(visible_selection.VisibleStart());
   RenderedPosition rendered_start(visible_start);
   rendered_start.PositionInGraphicsLayerBacking(selection.start, true);
@@ skipping 3297 matching lines @@
 void FrameView::SetAnimationHost(
     std::unique_ptr<CompositorAnimationHost> host) {
   animation_host_ = std::move(host);
 }
 
 LayoutUnit FrameView::CaretWidth() const {
   return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
 }
 
 }  // namespace blink