Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2847613002: Add net/spdy/PRESUBMIT.py. (Closed)

Created:
3 years, 8 months ago by Bence
Modified:
3 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add net/spdy/PRESUBMIT.py. Add net/spdy/PRESUBMIT.py that checks files in net/spdy/core and net/spdy/platform/api to make sure that classes, functions, and macros that have been factored out into net/spdy/platform are only used in that form in shared code. Review-Url: https://codereview.chromium.org/2847613002 Cr-Commit-Position: refs/heads/master@{#467969} Committed: https://chromium.googlesource.com/chromium/src/+/aa95dd2a139633f9e3a03f59b6a8d6468d8c9e28

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
A net/spdy/PRESUBMIT.py View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Bence
xunjieli: PTAL. Thank you.
3 years, 7 months ago (2017-04-27 09:55:09 UTC) #6
xunjieli
lgtm
3 years, 7 months ago (2017-04-27 18:20:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847613002/20001
3 years, 7 months ago (2017-04-28 12:35:29 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 12:49:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aa95dd2a139633f9e3a03f59b6a8...

Powered by Google App Engine
This is Rietveld 408576698