Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2847593002: [Merge to 3071] Stop emitting physical footprint on macOS 10.11. (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to 3071] Stop emitting physical footprint on macOS 10.11. > Despite the fact that the kernel implements physical footprint calculations on > macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For more > details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418. BUG=713854 Review-Url: https://codereview.chromium.org/2838703003 Cr-Commit-Position: refs/heads/master@{#466836} (cherry picked from commit 92efc4259724f8dcbc550cabfe57bc215343ebba)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/process/process_metrics_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_memory_details.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
erikchen
3 years, 7 months ago (2017-04-27 20:09:56 UTC) #1
Description was changed from

==========
[Merge to 3071] Stop emitting physical footprint on macOS 10.11.

> Despite the fact that the kernel implements physical footprint calculations on
> macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For
more
> details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418.

BUG=713854

Review-Url: https://codereview.chromium.org/2838703003
Cr-Commit-Position: refs/heads/master@{#466836}
(cherry picked from commit 92efc4259724f8dcbc550cabfe57bc215343ebba)
==========

to

==========
[Merge to 3071] Stop emitting physical footprint on macOS 10.11.

> Despite the fact that the kernel implements physical footprint calculations on
> macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For
more
> details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418.

BUG=713854

Review-Url: https://codereview.chromium.org/2838703003
Cr-Commit-Position: refs/heads/master@{#466836}
(cherry picked from commit 92efc4259724f8dcbc550cabfe57bc215343ebba)
==========

Powered by Google App Engine
This is Rietveld 408576698