Stop emitting physical footprint on macOS 10.11.

Stop emitting physical footprint on macOS 10.11.

Despite the fact that the kernel implements physical footprint calculations on
macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For more
details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418.

BUG=713854
Review-Url: https://codereview.chromium.org/2838703003
Cr-Commit-Position: refs/heads/master@{#466836}
Committed: https://chromium.googlesource.com/chromium/src/+/92efc4259724f8dcbc550cabfe57bc215343ebba

[erikchen, 2017-04-24 22:38:43]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2017-04-24 22:39:09]

erikchen@chromium.org changed reviewers:
+ asvitkine@chromium.org, mark@chromium.org

[erikchen, 2017-04-24 22:39:10]

mark: Please review base.
asvitkine: Please review chrome/browser/metrics/metrics_memory_details.cc.

[commit-bot: I haz the power, 2017-04-24 22:39:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-04-24 22:50:19]

lgtm

[commit-bot: I haz the power, 2017-04-24 23:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:32:45]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2017-04-24 23:57:21]

LGTM

https://codereview.chromium.org/2838703003/diff/1/base/process/process_metric...
File base/process/process_metrics_mac.cc (right):

https://codereview.chromium.org/2838703003/diff/1/base/process/process_metric...
base/process/process_metrics_mac.cc:298:
reinterpret_cast<task_info_t>(&task_vm_info), &count);
Note that you can also get rid of the OS version check and verify that “count”
on the way out >= (or ==) ChromeTaskVMInfoCount.

[erikchen, 2017-04-25 00:19:05]

https://codereview.chromium.org/2838703003/diff/1/base/process/process_metric...
File base/process/process_metrics_mac.cc (right):

https://codereview.chromium.org/2838703003/diff/1/base/process/process_metric...
base/process/process_metrics_mac.cc:298:
reinterpret_cast<task_info_t>(&task_vm_info), &count);
On 2017/04/24 23:57:21, Mark Mentovai wrote:
> Note that you can also get rid of the OS version check and verify that “count”
> on the way out >= (or ==) ChromeTaskVMInfoCount.

I'd like to avoid a syscall when I know the results are not going to be
meaningful.

[erikchen, 2017-04-25 00:19:43]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-04-25 00:20:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 00:28:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493079583022580, "parent_rev":
"5d00435578e14a407425e7bd19c7be8727254fe8", "commit_rev":
"92efc4259724f8dcbc550cabfe57bc215343ebba"}

[commit-bot: I haz the power, 2017-04-25 00:28:42]

Description was changed from

==========
Stop emitting physical footprint on macOS 10.11.

Despite the fact that the kernel implements physical footprint calculations on
macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For more
details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418.

BUG=713854
==========

to

==========
Stop emitting physical footprint on macOS 10.11.

Despite the fact that the kernel implements physical footprint calculations on
macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For more
details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418.

BUG=713854

Review-Url: https://codereview.chromium.org/2838703003
Cr-Commit-Position: refs/heads/master@{#466836}
Committed:
https://chromium.googlesource.com/chromium/src/+/92efc4259724f8dcbc550cabfe57...
==========

[commit-bot: I haz the power, 2017-04-25 00:28:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92efc4259724f8dcbc550cabfe57...