Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2847583003: Never showing context menu from the answer card. (Closed)

Created:
3 years, 7 months ago by vadimt
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Never showing context menu from the answer card. Per UX. Bug=712331 Review-Url: https://codereview.chromium.org/2847583003 Cr-Commit-Position: refs/heads/master@{#467759} Committed: https://chromium.googlesource.com/chromium/src/+/ca6cb1bca33700042f30ef9ffd6813b88aa37f36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/app_list/search_answer_web_contents_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
vadimt
3 years, 7 months ago (2017-04-27 00:58:19 UTC) #2
xiyuan
lgtm
3 years, 7 months ago (2017-04-27 02:52:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847583003/1
3 years, 7 months ago (2017-04-27 17:51:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/328057)
3 years, 7 months ago (2017-04-27 18:30:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847583003/1
3 years, 7 months ago (2017-04-27 18:53:50 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:40:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca6cb1bca33700042f30ef9ffd68...

Powered by Google App Engine
This is Rietveld 408576698