Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7127)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2847583002: [MD settings] css for row separator (Closed)
Patch Set: comment change Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index 5204d00657ace2e0ebd7cd40148354e81fa2a4e5..d0ff5f193d8b24b22259ce1ddf41eb233c21e9b0 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -318,8 +318,8 @@
outline: none;
}
- /* The secondary-action wraps a clickable sub-area of a .settings-box.
- * An example is the |sign out| button on the People settings.
+ /* TODO(dschuyler): replace with .vertical-rule-line.
Dan Beam 2017/04/27 00:11:03 wait, why can't we do this now?
dschuyler 2017/04/27 01:13:12 I was looking to hammer out the details before spr
+ * The secondary-action wraps a clickable sub-area of a .settings-box.
* Here is an example with and without a secondary action box:
*
* +-------------------------------------------------------+
@@ -346,6 +346,21 @@
border-top: var(--settings-separator-line);
}
+ /* The vertical-rule-line is a separator line like a horizontal rule
+ * <hr> tag, but goes the other way.
+ * An example is near the |sign out| button on the People settings. */
+ .vertical-rule-line {
Dan Beam 2017/04/27 00:11:03 nit: i like .separator more because it's not so ti
dschuyler 2017/04/27 01:13:12 Done.
+ -webkit-border-start: var(--settings-separator-line);
+ -webkit-margin-start: var(--settings-box-row-padding);
+ -webkit-padding-start: var(--settings-box-row-padding);
+ flex-shrink: 0;
+ height: 80%; /* e.g. 36px in a 45px row */
+ }
+
+ :-webkit-any(.settings-box, .list-item).two-line .vertical-rule-line {
+ height: 46px;
+ }
+
.settings-checkbox-spacer {
-webkit-margin-start: calc(
var(--checkbox-margin-start) +
« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698