[MD settings] css for row separator

chrome/browser/resources/settings/settings_shared_css.html

 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
 <link rel="import" href="settings_vars_css.html">
 
 <!-- Common styles for Material Design settings. -->
 <dom-module id="settings-shared">
   <template>
     <style include="cr-shared-style">
       /* Included here so we don't have to include "iron-positioning" in every
        * stylesheet. See crbug.com/498405. */
       [hidden] {
@@ skipping 300 matching lines @@
         align-items: center;
         flex: auto;
       }
 
       .no-outline,
       [scrollable] .no-outline {
         background: none;
         outline: none;
       }
 
-      /* The secondary-action wraps a clickable sub-area of a .settings-box.
-       * An example is the |sign out| button on the People settings.
+      /* TODO(dschuyler): replace with .vertical-rule-line.

[Dan Beam, 2017/04/27 00:11:03]

wait, why can't we do this now?

[dschuyler, 2017/04/27 01:13:12]

I was looking to hammer out the details before spreading it too far. e.g. name
changes. I also wanted to present an example of what I was suggesting to be sure
it was acceptable. 

+       * The secondary-action wraps a clickable sub-area of a .settings-box.
        * Here is an example with and without a secondary action box:
        *
        *  +-------------------------------------------------------+
        *  | Main action area .settings-box    | .secondary-action |
        *  +-------------------------------------------------------+
        *  | Another setting-box without a secondary-action        |
        *  +-------------------------------------------------------+ */
       :-webkit-any(.settings-box, .list-item) .secondary-action {
         -webkit-border-start: var(--settings-separator-line);
         -webkit-margin-start: 20px;
         -webkit-padding-start: 20px;
         align-items: center;
         display: flex;
         flex-shrink: 0;
         height: 36px;
       }
 
       :-webkit-any(.settings-box, .list-item).two-line .secondary-action {
         height: 46px;
       }
 
       /* Helper for a list frame to automatically avoid the separator line. */
       .vertical-list > *:not(:first-of-type) {
         border-top: var(--settings-separator-line);
       }
 
+      /* The vertical-rule-line is a separator line like a horizontal rule
+       * <hr> tag, but goes the other way.
+       * An example is near the |sign out| button on the People settings. */
+      .vertical-rule-line {

[Dan Beam, 2017/04/27 00:11:03]

nit: i like .separator more because it's not so tied to the presentation

[dschuyler, 2017/04/27 01:13:12]

Done.

+        -webkit-border-start: var(--settings-separator-line);
+        -webkit-margin-start: var(--settings-box-row-padding);
+        -webkit-padding-start: var(--settings-box-row-padding);
+        flex-shrink: 0;
+        height: 80%;  /* e.g. 36px in a 45px row */
+      }
+
+      :-webkit-any(.settings-box, .list-item).two-line .vertical-rule-line {
+        height: 46px;
+      }
+
       .settings-checkbox-spacer {
         -webkit-margin-start: calc(
             var(--checkbox-margin-start) +
             var(--checkbox-size) +
             var(--settings-control-spacing));
       }
 
       .favicon-image {
         background-repeat: no-repeat;
         background-size: contain;
@@ skipping 36 matching lines @@
         transform: rotate(-135deg);
       }
 
       .column-header {
         color: var(--paper-grey-600);
         font-weight: 500;
       }
     </style>
   </template>
 </dom-module>