Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2847573002: Fix about:sandbox display on Android. (Closed)

Created:
3 years, 8 months ago by Robert Sesek
Modified:
3 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix about:sandbox display on Android. Don't do work in DCHECKs. BUG=715792 R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2847573002 . Cr-Commit-Position: refs/heads/master@{#467677} Committed: https://chromium.googlesource.com/chromium/src/+/f29b4a2d08584052867b233984efba57fe9f893c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/renderer/sandbox_status_extension_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Robert Sesek
*facepalm*
3 years, 8 months ago (2017-04-26 22:49:11 UTC) #4
nasko
LGTM ;)
3 years, 8 months ago (2017-04-26 23:00:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847573002/1
3 years, 8 months ago (2017-04-26 23:18:52 UTC) #7
Robert Sesek
3 years, 7 months ago (2017-04-27 15:09:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f29b4a2d08584052867b233984efba57fe9f893c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698