Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2847563002: Rename WaitForTemperature to WaitForBatteryTemperature (Closed)

Created:
3 years, 8 months ago by rnephew (Reviews Here)
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, jbudorick
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Rename WaitForTemperature to WaitForBatteryTemperature It was unclear that this method waited for battery temperature. This renaming makes it clearer what is actually going on. Review-Url: https://codereview.chromium.org/2847563002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8062a5765bb78e3352fd394fe9626a762bea5089

Patch Set 1 #

Total comments: 2

Patch Set 2 : move documentation to public api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M devil/devil/android/tools/provision_devices.py View 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/core/platform.py View 1 1 chunk +7 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/android_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/platform_backend.py View 1 1 chunk +1 line, -5 lines 0 comments Download
M telemetry/telemetry/internal/story_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/story_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/testing/fakes/__init__.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
rnephew (Reviews Here)
Ned for telemetry changes. John for devil changes.
3 years, 8 months ago (2017-04-26 22:11:07 UTC) #2
jbudorick
On 2017/04/26 22:11:07, rnephew (Reviews Here) wrote: > Ned for telemetry changes. > > John ...
3 years, 8 months ago (2017-04-26 22:21:10 UTC) #3
nednguyen
lgtm https://codereview.chromium.org/2847563002/diff/1/telemetry/telemetry/internal/platform/platform_backend.py File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/2847563002/diff/1/telemetry/telemetry/internal/platform/platform_backend.py#newcode304 telemetry/telemetry/internal/platform/platform_backend.py:304: """Waits for device under test to cool down ...
3 years, 8 months ago (2017-04-26 22:27:31 UTC) #4
rnephew (Reviews Here)
https://codereview.chromium.org/2847563002/diff/1/telemetry/telemetry/internal/platform/platform_backend.py File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/2847563002/diff/1/telemetry/telemetry/internal/platform/platform_backend.py#newcode304 telemetry/telemetry/internal/platform/platform_backend.py:304: """Waits for device under test to cool down to ...
3 years, 8 months ago (2017-04-26 22:32:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847563002/20001
3 years, 8 months ago (2017-04-26 22:33:07 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 22:57:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698