Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2847533004: customtabs: Don't cache the Tab in PageLoadMetricsObserver. (Closed)

Created:
3 years, 7 months ago by Benoit L
Modified:
3 years, 7 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Don't cache the Tab in PageLoadMetricsObserver. Only the WebContents is needed, don't keep a reference to Tab, that keeps a reference to the Activity. BUG=715724 Review-Url: https://codereview.chromium.org/2847533004 Cr-Commit-Position: refs/heads/master@{#468060} Committed: https://chromium.googlesource.com/chromium/src/+/2f0dc80853e042b73036d403c6a9368b94e11e50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benoit L
3 years, 7 months ago (2017-04-28 15:32:57 UTC) #6
Yusuf
lgtm
3 years, 7 months ago (2017-04-28 17:22:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847533004/1
3 years, 7 months ago (2017-04-28 17:22:34 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:14:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f0dc80853e042b73036d403c6a9...

Powered by Google App Engine
This is Rietveld 408576698