PaymentHandler: Add a key prefix to avoid key conflicts with others.

PaymentHandler: Add a key prefix to avoid key conflicts with others.

The current implementation is using the service worker database (is based on
level DB) to store payment instrument data. The other SW features also use
the same way.
The instrument key is mapping with database key directly, So, the database key
might be conflict with other SW related features such as push notification.
To avoid this problem, this CL adds a prefix to instrument key.

BUG=661608
TEST=existing tests

Review-Url: https://codereview.chromium.org/2847533003
Cr-Commit-Position: refs/heads/master@{#467736}
Committed: https://chromium.googlesource.com/chromium/src/+/e052a49fd7fad23a559f05c54e6dce8671c13883

[zino, 2017-04-27 08:52:37]

Description was changed from

==========
PaymentHandler: Add a key prefix to avoid key conflicts with others.

The current implementation is using the service worker database (is based on
level DB) to store payment instrument data. The other SW features also use
the same way.
The instrument key is mapping with database key directly, So, the database key
might be conflict with other SW related features such as push notification.
To avoid this problem, this CL adds a prefix to instrument key.

BUG=661608
TEST=existing tests
==========

to

==========
PaymentHandler: Add a key prefix to avoid key conflicts with others.

The current implementation is using the service worker database (is based on
level DB) to store payment instrument data. The other SW features also use
the same way.
The instrument key is mapping with database key directly, So, the database key
might be conflict with other SW related features such as push notification.
To avoid this problem, this CL adds a prefix to instrument key.

BUG=661608
TEST=existing tests
==========

[zino, 2017-04-27 15:26:30]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org

[zino, 2017-04-27 15:26:42]

PTAL

[please use gerrit instead, 2017-04-27 15:37:40]

https://codereview.chromium.org/2847533003/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_app_database.cc (right):

https://codereview.chromium.org/2847533003/diff/1/content/browser/payments/pa...
content/browser/payments/payment_app_database.cc:29: return
base::StringPrintf("%s%s", kPaymentInstrumentKeyPrefix,
Stringprintf seems like an overkill. Why not this?

std::string CreatePaymentInstrumentKey(const std::string& instrument_key) {
  return "PaymentInstrument:" + instrument_key;
}

[zino, 2017-04-27 15:46:17]

On 2017/04/27 15:37:40, ಠ_ಠ wrote:
>
https://codereview.chromium.org/2847533003/diff/1/content/browser/payments/pa...
> File content/browser/payments/payment_app_database.cc (right):
> 
>
https://codereview.chromium.org/2847533003/diff/1/content/browser/payments/pa...
> content/browser/payments/payment_app_database.cc:29: return
> base::StringPrintf("%s%s", kPaymentInstrumentKeyPrefix,
> Stringprintf seems like an overkill. Why not this?
> 
> std::string CreatePaymentInstrumentKey(const std::string& instrument_key) {
>   return "PaymentInstrument:" + instrument_key;
> }

I did do that like service worker database:
https://cs.chromium.org/chromium/src/content/browser/service_worker/service_w...

But I agree with you. So, I've just fixed in a new patch set.

Thank you for review.

[please use gerrit instead, 2017-04-27 15:48:31]

lgtm % comment

https://codereview.chromium.org/2847533003/diff/20001/content/browser/payment...
File content/browser/payments/payment_app_database.cc (right):

https://codereview.chromium.org/2847533003/diff/20001/content/browser/payment...
content/browser/payments/payment_app_database.cc:11: #include
"base/strings/stringprintf.h"
No longer used.

[zino, 2017-04-27 15:56:54]

On 2017/04/27 15:48:31, ಠ_ಠ wrote:
> lgtm % comment
> 
>
https://codereview.chromium.org/2847533003/diff/20001/content/browser/payment...
> File content/browser/payments/payment_app_database.cc (right):
> 
>
https://codereview.chromium.org/2847533003/diff/20001/content/browser/payment...
> content/browser/payments/payment_app_database.cc:11: #include
> "base/strings/stringprintf.h"
> No longer used.

Thank you for review :)

[zino, 2017-04-27 16:26:29]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-04-27 16:26:29]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2847533003/#ps40001
(title: "PaymentHandler: Add a key prefix to avoid key conflicts with others.")

[commit-bot: I haz the power, 2017-04-27 16:26:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 17:57:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493310389278180,
"parent_rev": "8ccbf0490f18b6a6e3e4d004fbc27683cc215636", "commit_rev":
"e052a49fd7fad23a559f05c54e6dce8671c13883"}

[commit-bot: I haz the power, 2017-04-27 17:57:13]

Description was changed from

==========
PaymentHandler: Add a key prefix to avoid key conflicts with others.

The current implementation is using the service worker database (is based on
level DB) to store payment instrument data. The other SW features also use
the same way.
The instrument key is mapping with database key directly, So, the database key
might be conflict with other SW related features such as push notification.
To avoid this problem, this CL adds a prefix to instrument key.

BUG=661608
TEST=existing tests
==========

to

==========
PaymentHandler: Add a key prefix to avoid key conflicts with others.

The current implementation is using the service worker database (is based on
level DB) to store payment instrument data. The other SW features also use
the same way.
The instrument key is mapping with database key directly, So, the database key
might be conflict with other SW related features such as push notification.
To avoid this problem, this CL adds a prefix to instrument key.

BUG=661608
TEST=existing tests

Review-Url: https://codereview.chromium.org/2847533003
Cr-Commit-Position: refs/heads/master@{#467736}
Committed:
https://chromium.googlesource.com/chromium/src/+/e052a49fd7fad23a559f05c54e6d...
==========

[commit-bot: I haz the power, 2017-04-27 17:57:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e052a49fd7fad23a559f05c54e6d...