Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2847533002: Update mp4 vp9 test files to follow v1.0 spec (Closed)

Created:
3 years, 7 months ago by kqyang
Modified:
3 years, 7 months ago
Reviewers:
chcunningham, xhwang
CC:
chromium-reviews, chfremer+watch_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mp4 vp9 test files to follow v1.0 spec - Also updated relevant codec strings to match what is in the file - Also Fix typo in mp4 vp9 encrypted media supported types test BUG=580623 Review-Url: https://codereview.chromium.org/2847533002 Cr-Commit-Position: refs/heads/master@{#469865} Committed: https://chromium.googlesource.com/chromium/src/+/bfe1030ac8d3e23bd238376e9aeab0bfb3437ee7

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : Update readme #

Patch Set 4 : Rebased #

Patch Set 5 : Address build breaks on some configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M media/test/data/README View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M media/test/data/bear-320x240-v_frag-vp9.mp4 View 1 2 3 4 Binary file 0 comments Download
M media/test/data/bear-320x240-v_frag-vp9-cenc.mp4 View 1 2 3 4 Binary file 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 28 (15 generated)
kqyang
chcunningham@ xhwang@ can one of you take a look? It is just some trivial changes. ...
3 years, 7 months ago (2017-05-04 21:44:57 UTC) #7
xhwang
lg, just two more places that needs to be fixed. Also, since we are changing ...
3 years, 7 months ago (2017-05-04 22:20:02 UTC) #8
kqyang
On 2017/05/04 22:20:02, xhwang wrote: > lg, just two more places that needs to be ...
3 years, 7 months ago (2017-05-04 23:05:54 UTC) #9
kqyang
Thanks for reviewing. https://codereview.chromium.org/2847533002/diff/1/chrome/browser/media/encrypted_media_supported_types_browsertest.cc File chrome/browser/media/encrypted_media_supported_types_browsertest.cc (right): https://codereview.chromium.org/2847533002/diff/1/chrome/browser/media/encrypted_media_supported_types_browsertest.cc#newcode602 chrome/browser/media/encrypted_media_supported_types_browsertest.cc:602: kVideoWebMMimeType, video_common_codecs(), kExternalClearKey)); On 2017/05/04 22:20:02, ...
3 years, 7 months ago (2017-05-04 23:06:14 UTC) #10
xhwang
lgtm
3 years, 7 months ago (2017-05-04 23:11:14 UTC) #11
chcunningham
Thanks for updating. LGTM
3 years, 7 months ago (2017-05-05 01:16:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847533002/20001
3 years, 7 months ago (2017-05-05 02:36:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/419201)
3 years, 7 months ago (2017-05-05 04:56:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847533002/30001
3 years, 7 months ago (2017-05-05 20:54:54 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/286998)
3 years, 7 months ago (2017-05-05 22:31:33 UTC) #21
kqyang
I thought linux_chromium_rel_ng and linux_chromium_asan_rel_ng are the same except linux_chromium_asan_rel_ng has asan enabled but actually ...
3 years, 7 months ago (2017-05-05 23:45:21 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847533002/40001
3 years, 7 months ago (2017-05-05 23:46:09 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 19:06:59 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bfe1030ac8d3e23bd238376e9aea...

Powered by Google App Engine
This is Rietveld 408576698