chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2847513002: Break page load metrics test dependency on IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2847513002: Break page load metrics test dependency on IPC. (Closed)

Patch Set: add expectation in wait method Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('j') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 17313deceb572332e9e7d749478e99658df3d1b4..ab49ed32f686c8b043912d1bddd71693a56c6289 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -144,9 +144,7 @@ void PageLoadMetricsObserverTestHarness::SimulateTimingUpdate(

void PageLoadMetricsObserverTestHarness::SimulateTimingAndMetadataUpdate(

const PageLoadTiming& timing,

const PageLoadMetadata& metadata) {

- observer_->OnMessageReceived(PageLoadMetricsMsg_TimingUpdated(

- observer_->routing_id(), timing, metadata),

- web_contents()->GetMainFrame());

+ observer_->OnTimingUpdated(web_contents()->GetMainFrame(), timing, metadata);

}

void PageLoadMetricsObserverTestHarness::SimulateLoadedResource(