chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc - Issue 2847513002: Break page load metrics test dependency on IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2847513002: Break page load metrics test dependency on IPC. (Closed)

Patch Set: add expectation in wait method Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

index 2466dd157bc42d9a0fc3d61dca65c40a336254da..a301058e1312753aae6341f00f1023fe9e375bcf 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

@@ -167,10 +167,7 @@ class MetricsWebContentsObserverTest : public ChromeRenderViewHostTestHarness {

void SimulateTimingUpdate(const PageLoadTiming& timing,

content::RenderFrameHost* render_frame_host) {

- ASSERT_TRUE(observer_->OnMessageReceived(

- PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing,

- PageLoadMetadata()),

- render_frame_host));

+ observer_->OnTimingUpdated(render_frame_host, timing, PageLoadMetadata());

}

void AttachObserver() {