[CrOS Tether] Remove the ManagedTetherProperties dictionary.

[CrOS Tether] Remove the ManagedTetherProperties dictionary.

All instances of ManagedTetherProperties are replaced by (non-managed) TetherProperties. This change is due to the fact that tether properties are not managed by policy.

This CL also adds API tests for the functions which can return Tether networks.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847453002
Cr-Commit-Position: refs/heads/master@{#467815}
Committed: https://chromium.googlesource.com/chromium/src/+/b541a5aec14eb589fdd76957efe67597b6411508

[Kyle Horimoto, 2017-04-26 17:26:39]

Description was changed from

==========
[CrOS Tether] Remove the ManagedTetherProperties dictionary.

All instances of ManagedTetherProperties are replaced by (non-managed)
TetherProperties. This change is due to the fact that tether properties are not
managed by policy.

This CL is a work in progress - not yet ready for review.

BUG=672263
==========

to

==========
[CrOS Tether] Remove the ManagedTetherProperties dictionary.

All instances of ManagedTetherProperties are replaced by (non-managed)
TetherProperties. This change is due to the fact that tether properties are not
managed by policy.

This CL is a work in progress - not yet ready for review.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-26 17:37:53]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-04-26 17:37:53]

We need to update the IDL to support networkingPrivate.getState, but the detail
page uses getManagedProperties for primary users, so this *should* work.

Have you tried adding a test to networking_private_apitest.cc? We should do that
regardless.

https://codereview.chromium.org/2847453002/diff/1/extensions/common/api/netwo...
File extensions/common/api/networking_private.idl (right):

https://codereview.chromium.org/2847453002/diff/1/extensions/common/api/netwo...
extensions/common/api/networking_private.idl:741: NetworkType Type;
You also need:
TetherStateProperties? Tether;

You'll need to define TetherStateProperties as well.
(I realize there is a lot of redundancy here, but... it's complicated).

[stevenjb, 2017-04-26 17:38:27]

On 2017/04/26 17:37:53, stevenjb wrote:
> We need to update the IDL to support networkingPrivate.getState, but the
detail
> page uses getManagedProperties for primary users, so this *should* work.
> 
> Have you tried adding a test to networking_private_apitest.cc? We should do
that
> regardless.
> 
>
https://codereview.chromium.org/2847453002/diff/1/extensions/common/api/netwo...
> File extensions/common/api/networking_private.idl (right):
> 
>
https://codereview.chromium.org/2847453002/diff/1/extensions/common/api/netwo...
> extensions/common/api/networking_private.idl:741: NetworkType Type;
> You also need:
> TetherStateProperties? Tether;
> 
> You'll need to define TetherStateProperties as well.
> (I realize there is a lot of redundancy here, but... it's complicated).

(er, sorry, networking_private_chromeos_apitest is what you really want)

[Kyle Horimoto, 2017-04-26 23:25:12]

Description was changed from

==========
[CrOS Tether] Remove the ManagedTetherProperties dictionary.

All instances of ManagedTetherProperties are replaced by (non-managed)
TetherProperties. This change is due to the fact that tether properties are not
managed by policy.

This CL is a work in progress - not yet ready for review.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[CrOS Tether] Remove the ManagedTetherProperties dictionary.

All instances of ManagedTetherProperties are replaced by (non-managed)
TetherProperties. This change is due to the fact that tether properties are not
managed by policy.

This CL also adds API tests for the functions which can return Tether networks.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Kyle Horimoto, 2017-04-26 23:26:22]

khorimoto@chromium.org changed reviewers:
+ rockot@chromium.org

[Kyle Horimoto, 2017-04-26 23:26:23]

Ready for review. PTAL.

rockot: networking_private.idl change.
stevenjb: Everything else.

https://codereview.chromium.org/2847453002/diff/1/extensions/common/api/netwo...
File extensions/common/api/networking_private.idl (right):

https://codereview.chromium.org/2847453002/diff/1/extensions/common/api/netwo...
extensions/common/api/networking_private.idl:741: NetworkType Type;
On 2017/04/26 17:37:53, stevenjb wrote:
> You also need:
> TetherStateProperties? Tether;
> 
> You'll need to define TetherStateProperties as well.
> (I realize there is a lot of redundancy here, but... it's complicated).

As discussed offline, we are using TetherProperties for both cases.

[Ken Rockot(use gerrit already), 2017-04-27 14:54:21]

lgtm

[stevenjb, 2017-04-27 19:20:16]

lgtm

[Kyle Horimoto, 2017-04-27 19:21:16]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2017-04-27 19:21:16]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2847453002/#ps40001
(title: "Fixed broken OncValidator test.")

[commit-bot: I haz the power, 2017-04-27 19:32:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:54:41]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kyle Horimoto, 2017-04-27 20:12:17]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:12:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:49:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493323937399740,
"parent_rev": "20d7dfb2f40463c2921495a48a3f571094978d2b", "commit_rev":
"b541a5aec14eb589fdd76957efe67597b6411508"}

[commit-bot: I haz the power, 2017-04-28 01:50:05]

Description was changed from

==========
[CrOS Tether] Remove the ManagedTetherProperties dictionary.

All instances of ManagedTetherProperties are replaced by (non-managed)
TetherProperties. This change is due to the fact that tether properties are not
managed by policy.

This CL also adds API tests for the functions which can return Tether networks.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[CrOS Tether] Remove the ManagedTetherProperties dictionary.

All instances of ManagedTetherProperties are replaced by (non-managed)
TetherProperties. This change is due to the fact that tether properties are not
managed by policy.

This CL also adds API tests for the functions which can return Tether networks.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847453002
Cr-Commit-Position: refs/heads/master@{#467815}
Committed:
https://chromium.googlesource.com/chromium/src/+/b541a5aec14eb589fdd76957efe6...
==========

[commit-bot: I haz the power, 2017-04-28 01:50:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b541a5aec14eb589fdd76957efe6...