Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2847353002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2847353002 Cr-Commit-Position: refs/heads/master@{#468268} Committed: https://chromium.googlesource.com/chromium/src/+/83fe36db187d3c4959fa2f76cb772cea5a78c139

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M chrome/browser/safe_browsing/download_feedback_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 1 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:27:06 UTC) #6
mattm
lgtm
3 years, 7 months ago (2017-05-01 01:08:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847353002/20001
3 years, 7 months ago (2017-05-01 01:32:21 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 02:30:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/83fe36db187d3c4959fa2f76cb77...

Powered by Google App Engine
This is Rietveld 408576698