Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2847333002: Image Capture: add idlharness WPT (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
dougt, scheib
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: add idlharness WPT IDL copy-pasted from https://w3c.github.io/mediacapture-image/#idl-index BUG=706434 Review-Url: https://codereview.chromium.org/2847333002 Cr-Commit-Position: refs/heads/master@{#468833} Committed: https://chromium.googlesource.com/chromium/src/+/30b7eefae3ecdbe8184ef5f55416e8ed02c6d2e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/idlharness.html View 1 chunk +185 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/idlharness-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
mcasas
dougt@ PTAL/RS plz
3 years, 7 months ago (2017-05-02 22:12:13 UTC) #4
dougt
On 2017/05/02 22:12:13, mcasas wrote: > dougt@ PTAL/RS plz lgtm. I presume the idlharness-expected.txt file ...
3 years, 7 months ago (2017-05-02 22:34:30 UTC) #6
mcasas
On 2017/05/02 22:34:30, dougt wrote: > On 2017/05/02 22:12:13, mcasas wrote: > > dougt@ PTAL/RS ...
3 years, 7 months ago (2017-05-02 22:39:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847333002/1
3 years, 7 months ago (2017-05-02 23:27:12 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-02 23:27:15 UTC) #13
mcasas
scheib@ RS plz
3 years, 7 months ago (2017-05-02 23:38:46 UTC) #15
scheib
lgtm
3 years, 7 months ago (2017-05-03 00:18:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847333002/1
3 years, 7 months ago (2017-05-03 00:21:37 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 00:27:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30b7eefae3ecdbe8184ef5f55416...

Powered by Google App Engine
This is Rietveld 408576698