chromeos: convert remaining AshTest usage to AshTestBase

chromeos: convert remaining AshTest usage to AshTestBase

And remove the now unused test related classes.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2847283002
Cr-Commit-Position: refs/heads/master@{#468352}
Committed: https://chromium.googlesource.com/chromium/src/+/28eafdc5710b521efa47ec4bc40ebf985ee9ff20

[sky, 2017-04-28 21:57:04]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 21:57:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 00:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 00:14:18]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-29 01:02:23]

https://codereview.chromium.org/2847283002/diff/1/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc (right):

https://codereview.chromium.org/2847283002/diff/1/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc:50: class
WorkspaceLayoutManagerKeyboardTest2 : public test::AshTestBase {
We have a WorkspaceLayoutManagerKeyboardTest in another file, so I renamed this
to make it clearer.

https://codereview.chromium.org/2847283002/diff/1/ash/wm_window_unittest.cc
File ash/wm_window_unittest.cc (left):

https://codereview.chromium.org/2847283002/diff/1/ash/wm_window_unittest.cc#o...
ash/wm_window_unittest.cc:55: // Verifies OnWindowVisibilityChanged() is called
on a aura::WindowObserver
This test was useful when we had ui::Window. As we no longer have ui::Window,
this test isn't particularly useful.

[James Cook, 2017-05-01 16:38:09]

LGTM

https://codereview.chromium.org/2847283002/diff/20001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2847283002/diff/20001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_layout_manager_unittest.cc:1176:
WmWindowTestApi::GlobalMinimumSizeLock min_size_lock;
Why do so many of these tests need the GlobalMinimumSizeLock? Leave a comment
somewhere? The header docs for GlobalMinimumSizeLock don't really explain *why*
a test that doesn't appear to use WmWindow would need it.

[sky, 2017-05-01 16:47:49]

On 2017/05/01 16:38:09, James Cook wrote:
> LGTM
> 
>
https://codereview.chromium.org/2847283002/diff/20001/ash/wm/workspace/worksp...
> File ash/wm/workspace/workspace_layout_manager_unittest.cc (right):
> 
>
https://codereview.chromium.org/2847283002/diff/20001/ash/wm/workspace/worksp...
> ash/wm/workspace/workspace_layout_manager_unittest.cc:1176:
> WmWindowTestApi::GlobalMinimumSizeLock min_size_lock;
> Why do so many of these tests need the GlobalMinimumSizeLock? Leave a comment
> somewhere? The header docs for GlobalMinimumSizeLock don't really explain
*why*
> a test that doesn't appear to use WmWindow would need it.

Added comment.

[sky, 2017-05-01 16:47:56]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-01 16:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2847283002/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2017-05-01 16:48:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:00:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493657276538660,
"parent_rev": "7993a7f17e118c7e7eeb5762aca56db699c768e5", "commit_rev":
"28eafdc5710b521efa47ec4bc40ebf985ee9ff20"}

[commit-bot: I haz the power, 2017-05-01 18:00:21]

Description was changed from

==========
chromeos: convert remaining AshTest usage to AshTestBase

And remove the now unused test related classes.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org
==========

to

==========
chromeos: convert remaining AshTest usage to AshTestBase

And remove the now unused test related classes.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2847283002
Cr-Commit-Position: refs/heads/master@{#468352}
Committed:
https://chromium.googlesource.com/chromium/src/+/28eafdc5710b521efa47ec4bc40e...
==========

[commit-bot: I haz the power, 2017-05-01 18:00:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/28eafdc5710b521efa47ec4bc40e...