Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2847273002:
Reverse postscript flag direction (Closed)
DescriptionReverse postscript flag direction
Enable post script printing by default, modify flag to turn off the
feature so that it can be used as a killswitch if needed.
BUG=706218
Review-Url: https://codereview.chromium.org/2847273002
Cr-Commit-Position: refs/heads/master@{#468370}
Committed: https://chromium.googlesource.com/chromium/src/+/556837e4a02da291129e2ad1d945b88681ed8ec3
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix histograms. Also remove print scaling #Patch Set 3 : Rebase #
Total comments: 2
Patch Set 4 : Restore previous values to histograms.xml #
Messages
Total messages: 38 (27 generated)
Description was changed from ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. BUG=706218 ========== to ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. BUG=706218 ==========
rbpotter@chromium.org changed reviewers: + thestig@chromium.org
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2847273002/diff/1/chrome/browser/flag_descrip... File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2847273002/diff/1/chrome/browser/flag_descrip... chrome/browser/flag_descriptions.cc:2735: "Disables postscript generation when printing to postscript capable " This message is shown to users, so PostScript, and EMF.
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Description was changed from ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. BUG=706218 ========== to ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. Also remove the print scaling histogram entries as they are no longer needed. BUG=706218 ==========
https://codereview.chromium.org/2847273002/diff/1/chrome/browser/flag_descrip... File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2847273002/diff/1/chrome/browser/flag_descrip... chrome/browser/flag_descriptions.cc:2735: "Disables postscript generation when printing to postscript capable " On 2017/04/28 20:54:08, Lei Zhang wrote: > This message is shown to users, so PostScript, and EMF. Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2847273002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. Also remove the print scaling histogram entries as they are no longer needed. BUG=706218 ========== to ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. Also remove the print scaling histogram entries as they are no longer needed (see https://codereview.chromium.org/2834453004/) BUG=706218 ==========
rbpotter@chromium.org changed reviewers: + isherman@chromium.org
+isherman@ for histograms
histograms.xml LGTM % a comment: https://codereview.chromium.org/2847273002/diff/40001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2847273002/diff/40001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:104313: - <int value="1989877708" label="PostScriptPrinting:enabled"/> Please leave the old values in place, so that historical data remains viewable.
On 2017/04/29 07:13:55, Ilya Sherman wrote: > histograms.xml LGTM % a comment: > > https://codereview.chromium.org/2847273002/diff/40001/tools/metrics/histogram... > File tools/metrics/histograms/histograms.xml (left): > > https://codereview.chromium.org/2847273002/diff/40001/tools/metrics/histogram... > tools/metrics/histograms/histograms.xml:104313: - <int value="1989877708" > label="PostScriptPrinting:enabled"/> > Please leave the old values in place, so that historical data remains viewable. Restored the old values to histograms.xml
https://codereview.chromium.org/2847273002/diff/40001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2847273002/diff/40001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:104313: - <int value="1989877708" label="PostScriptPrinting:enabled"/> On 2017/04/29 07:13:55, Ilya Sherman wrote: > Please leave the old values in place, so that historical data remains viewable. Done.
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2847273002/#ps60001 (title: "Restore previous values to histograms.xml")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493664147047940,
"parent_rev": "0e8654a86c07ce53d0fdb70f0b35609e59d08dcf", "commit_rev":
"556837e4a02da291129e2ad1d945b88681ed8ec3"}
Message was sent while issue was closed.
Description was changed from ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. Also remove the print scaling histogram entries as they are no longer needed (see https://codereview.chromium.org/2834453004/) BUG=706218 ========== to ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. Also remove the print scaling histogram entries as they are no longer needed (see https://codereview.chromium.org/2834453004/) BUG=706218 Review-Url: https://codereview.chromium.org/2847273002 Cr-Commit-Position: refs/heads/master@{#468370} Committed: https://chromium.googlesource.com/chromium/src/+/556837e4a02da291129e2ad1d945... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/556837e4a02da291129e2ad1d945...
Message was sent while issue was closed.
Description was changed from ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. Also remove the print scaling histogram entries as they are no longer needed (see https://codereview.chromium.org/2834453004/) BUG=706218 Review-Url: https://codereview.chromium.org/2847273002 Cr-Commit-Position: refs/heads/master@{#468370} Committed: https://chromium.googlesource.com/chromium/src/+/556837e4a02da291129e2ad1d945... ========== to ========== Reverse postscript flag direction Enable post script printing by default, modify flag to turn off the feature so that it can be used as a killswitch if needed. BUG=706218 Review-Url: https://codereview.chromium.org/2847273002 Cr-Commit-Position: refs/heads/master@{#468370} Committed: https://chromium.googlesource.com/chromium/src/+/556837e4a02da291129e2ad1d945... ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
