Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2847253003: Allocate a FrameSinkId for RenderWidgetHostViewAura in mus+ash (Closed)

Created:
3 years, 7 months ago by Saman Sami
Modified:
3 years, 7 months ago
Reviewers:
Fady Samuel, jam
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allocate a FrameSinkId for RenderWidgetHostViewAura in mus+ash RenderWidgetHostViewChildFrame expects its parent to have a valid FrameSinkId. Make sure RenderWidgetHostViewAura has a FrameSinkId even if DelegatedFrameHost is not used (in mus+ash). BUG=706553 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2847253003 Cr-Commit-Position: refs/heads/master@{#468179} Committed: https://chromium.googlesource.com/chromium/src/+/b399a05453d7b3e2dfdec67865fefe6953bcc59e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Saman Sami
jam: Please review RenderWidgetHostViewAura
3 years, 7 months ago (2017-04-28 19:33:00 UTC) #6
Fady Samuel
lgtm
3 years, 7 months ago (2017-04-28 19:47:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847253003/1
3 years, 7 months ago (2017-04-28 23:22:48 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 23:28:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b399a05453d7b3e2dfdec67865fe...

Powered by Google App Engine
This is Rietveld 408576698