diagnose_apk_bloat.py: fix error messages and simplify rev order.

diagnose_apk_bloat.py: fix error messages and simplify rev order.

  * Improve error messages related to supplying invalid rev or
--reference-rev args
  * Change diff classes to use "before" and "after" instead of a list
of dirs to make the code a little easier to follow
  * Fix Linux issues and make --cloud work for Linux

BUG=695182
Review-Url: https://codereview.chromium.org/2847243005
Cr-Commit-Position: refs/heads/master@{#468690}
Committed: https://chromium.googlesource.com/chromium/src/+/c0fd70a81b94dcd6c976b51fab798c0178a33613

[estevenson, 2017-04-28 22:15:06]

Description was changed from

==========
diagnose_apk_bloat.py: fix error messages and simplify rev order.

This CL makes error messages related to supplying invalid rev or
--reference-rev args more accurate.

Also change diff classes to use "before" and "after" instead of a list
of dirs to make the code a little easier to follow.

BUG=695182
==========

to

==========
diagnose_apk_bloat.py: fix error messages and simplify rev order.

This CL makes error messages related to supplying invalid rev or
--reference-rev args more accurate.

Also change diff classes to use "before" and "after" instead of a list
of dirs to make the code a little easier to follow.

BUG=695182
==========

[estevenson, 2017-04-28 22:15:06]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-05-01 22:26:12]

Description was changed from

==========
diagnose_apk_bloat.py: fix error messages and simplify rev order.

This CL makes error messages related to supplying invalid rev or
--reference-rev args more accurate.

Also change diff classes to use "before" and "after" instead of a list
of dirs to make the code a little easier to follow.

BUG=695182
==========

to

==========
diagnose_apk_bloat.py: fix error messages and simplify rev order.

  * Improve error messages related to supplying invalid rev or
--reference-rev args
  * Change diff classes to use "before" and "after" instead of a list
of dirs to make the code a little easier to follow
  * Fix Linux issues and make --cloud work for Linux

BUG=695182
==========

[agrieve, 2017-05-02 00:16:52]

Nice cleanup. just one nit. lgtm

https://codereview.chromium.org/2847243005/diff/60001/tools/binary_size/diagn...
File tools/binary_size/diagnose_apk_bloat.py (right):

https://codereview.chromium.org/2847243005/diff/60001/tools/binary_size/diagn...
tools/binary_size/diagnose_apk_bloat.py:739: _VerifyUserAccepts('Linux diffs are
less useful than Android diffs, '
nit: Worth being more specific here I think. Maybe just say linux diffs have
known deficiencies and link to the crbug about linux support for supersize.

[estevenson, 2017-05-02 16:00:10]

https://codereview.chromium.org/2847243005/diff/60001/tools/binary_size/diagn...
File tools/binary_size/diagnose_apk_bloat.py (right):

https://codereview.chromium.org/2847243005/diff/60001/tools/binary_size/diagn...
tools/binary_size/diagnose_apk_bloat.py:739: _VerifyUserAccepts('Linux diffs are
less useful than Android diffs, '
On 2017/05/02 00:16:52, agrieve wrote:
> nit: Worth being more specific here I think. Maybe just say linux diffs have
> known deficiencies and link to the crbug about linux support for supersize.

Done.

[estevenson, 2017-05-02 17:00:58]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-05-02 17:00:59]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2847243005/#ps100001
(title: "diagnose_apk_bloat.py: fix error messages and simplify rev order.")

[commit-bot: I haz the power, 2017-05-02 17:01:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:11:24]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493744458639540,
"parent_rev": "a5b89b9ead605958c0c84c07a0cb50bce4ba60b3", "commit_rev":
"c0fd70a81b94dcd6c976b51fab798c0178a33613"}

[commit-bot: I haz the power, 2017-05-02 17:11:42]

Description was changed from

==========
diagnose_apk_bloat.py: fix error messages and simplify rev order.

  * Improve error messages related to supplying invalid rev or
--reference-rev args
  * Change diff classes to use "before" and "after" instead of a list
of dirs to make the code a little easier to follow
  * Fix Linux issues and make --cloud work for Linux

BUG=695182
==========

to

==========
diagnose_apk_bloat.py: fix error messages and simplify rev order.

  * Improve error messages related to supplying invalid rev or
--reference-rev args
  * Change diff classes to use "before" and "after" instead of a list
of dirs to make the code a little easier to follow
  * Fix Linux issues and make --cloud work for Linux

BUG=695182

Review-Url: https://codereview.chromium.org/2847243005
Cr-Commit-Position: refs/heads/master@{#468690}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0fd70a81b94dcd6c976b51fab79...
==========

[commit-bot: I haz the power, 2017-05-02 17:11:43]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c0fd70a81b94dcd6c976b51fab79...