Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2847203002: Replace ASSERT_NOT_REACHED with NOTREACHED in build/scripts/templates/ (Closed)

Created:
3 years, 7 months ago by pilgrim_google
Modified:
3 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED with NOTREACHED in build/scripts/templates/ BUG=707642 Review-Url: https://codereview.chromium.org/2847203002 Cr-Commit-Position: refs/heads/master@{#468453} Committed: https://chromium.googlesource.com/chromium/src/+/65003efd91d69d2e4688e4b699dfb1b825683266

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
pilgrim_google
3 years, 7 months ago (2017-04-28 17:19:00 UTC) #3
haraken
LGTM
3 years, 7 months ago (2017-04-29 02:13:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847203002/20001
3 years, 7 months ago (2017-05-01 20:07:27 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:20:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/65003efd91d69d2e4688e4b699df...

Powered by Google App Engine
This is Rietveld 408576698