|
|
Created:
3 years, 7 months ago by lunalu1 Modified:
3 years, 7 months ago Reviewers:
Rick Byers CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable UseCounterTests on Android
Tests re-enabled are:
UseCounterTest.RecordingFeatures, UseCounterTest.SVGImageContextFeatures,
UseCounterTest.InspectorDisablesMeasurement, UseCounterTest.MutedDocuments
BUG=667913, 654502
Review-Url: https://codereview.chromium.org/2847173002
Cr-Commit-Position: refs/heads/master@{#468097}
Committed: https://chromium.googlesource.com/chromium/src/+/285ad523ac8e142089580e9b2669926d6f9e46d8
Patch Set 1 #Patch Set 2 : Update rebase #
Messages
Total messages: 22 (16 generated)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lunalu@chromium.org changed reviewers: + rbyers@chromium.org
Hi Rick, I try to reproduce the crash locally on a Nexus 4 (lolipop) phone and all tests seemed to pass. I am re-enabling all the tests on Android. PTAL Thanks
Yeah if you tried but failed to reproduce an issue locally, then let's try turning it back on and see if any of the bots complain. If we get failures on the bots we should be prepared to disable again right away (eg. revert this CL) while we investigate. LGTM
On 2017/04/28 15:28:45, Rick Byers wrote: > Yeah if you tried but failed to reproduce an issue locally, then let's try > turning it back on and see if any of the bots complain. If we get failures on > the bots we should be prepared to disable again right away (eg. revert this CL) > while we investigate. > > LGTM Please try adding whatever additional trybots you can find for ASAN or Android devices. Eg. maybe android_n5x_swarming_dbg android_n5x_swarming_rel bots?
The CQ bit was unchecked by lunalu@chromium.org
The CQ bit was checked by lunalu@chromium.org
The CQ bit was unchecked by lunalu@chromium.org
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by lunalu@chromium.org
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
The CQ bit was unchecked by lunalu@chromium.org
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org Link to the patchset: https://codereview.chromium.org/2847173002/#ps20001 (title: "Update rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493403824753390, "parent_rev": "7d0f29cf86073f026098badc2dfe6ee7a7520b65", "commit_rev": "285ad523ac8e142089580e9b2669926d6f9e46d8"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable UseCounterTests on Android Tests re-enabled are: UseCounterTest.RecordingFeatures, UseCounterTest.SVGImageContextFeatures, UseCounterTest.InspectorDisablesMeasurement, UseCounterTest.MutedDocuments BUG=667913,654502 ========== to ========== Re-enable UseCounterTests on Android Tests re-enabled are: UseCounterTest.RecordingFeatures, UseCounterTest.SVGImageContextFeatures, UseCounterTest.InspectorDisablesMeasurement, UseCounterTest.MutedDocuments BUG=667913,654502 Review-Url: https://codereview.chromium.org/2847173002 Cr-Commit-Position: refs/heads/master@{#468097} Committed: https://chromium.googlesource.com/chromium/src/+/285ad523ac8e142089580e9b2669... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/285ad523ac8e142089580e9b2669...
Message was sent while issue was closed.
I was trying to run additional try bots and this CL got landed by accident (it didn't let me run bots unless I set the CL to be committed for some reason). I will be watching the build bots. Hopefully nothing will break due to this change. |