Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 2847173002: Re-enable UseCounterTests on Android (Closed)

Created:
3 years, 7 months ago by lunalu1
Modified:
3 years, 7 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable UseCounterTests on Android Tests re-enabled are: UseCounterTest.RecordingFeatures, UseCounterTest.SVGImageContextFeatures, UseCounterTest.InspectorDisablesMeasurement, UseCounterTest.MutedDocuments BUG=667913, 654502 Review-Url: https://codereview.chromium.org/2847173002 Cr-Commit-Position: refs/heads/master@{#468097} Committed: https://chromium.googlesource.com/chromium/src/+/285ad523ac8e142089580e9b2669926d6f9e46d8

Patch Set 1 #

Patch Set 2 : Update rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounterTest.cpp View 4 chunks +4 lines, -28 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
lunalu1
Hi Rick, I try to reproduce the crash locally on a Nexus 4 (lolipop) phone ...
3 years, 7 months ago (2017-04-28 15:18:27 UTC) #4
Rick Byers
Yeah if you tried but failed to reproduce an issue locally, then let's try turning ...
3 years, 7 months ago (2017-04-28 15:28:45 UTC) #5
Rick Byers
On 2017/04/28 15:28:45, Rick Byers wrote: > Yeah if you tried but failed to reproduce ...
3 years, 7 months ago (2017-04-28 15:34:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847173002/20001
3 years, 7 months ago (2017-04-28 18:24:38 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/285ad523ac8e142089580e9b2669926d6f9e46d8
3 years, 7 months ago (2017-04-28 19:43:08 UTC) #21
lunalu1
3 years, 7 months ago (2017-05-01 17:51:56 UTC) #22
Message was sent while issue was closed.
I was trying to run additional try bots and this CL got landed by accident (it
didn't let me run bots unless I set the CL to be committed for some reason).

I will be watching the build bots. Hopefully nothing will break due to this
change.

Powered by Google App Engine
This is Rietveld 408576698