Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2847133002: Abort the SVG filter content recording if the FilterData was dropped (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Abort the SVG filter content recording if the FilterData was dropped In the (rare) case of a recording being started and the FilterData structure being yanked away (and destroyed) from under SVGFilterPainter's feet, we need to put the PaintController in a consistent state before destroying it. Add a new method SVGFilterRecordingContext::Abort() and call that when SVGFilterPainter::FinishEffect encounters a null FilterData for the LayoutObject. BUG=713024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2847133002 Cr-Commit-Position: refs/heads/master@{#468092} Committed: https://chromium.googlesource.com/chromium/src/+/b599adbfc98de4cf9d71047c5ca092c9ce51e302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/SVGFilterPainter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 2 chunks +13 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
fs
3 years, 7 months ago (2017-04-28 15:11:56 UTC) #5
Stephen Chennney
lgtm number 2
3 years, 7 months ago (2017-04-28 16:04:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847133002/1
3 years, 7 months ago (2017-04-28 19:23:37 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 19:34:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b599adbfc98de4cf9d71047c5ca0...

Powered by Google App Engine
This is Rietveld 408576698