Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2847063002: [wasm] Ensure postMessage doesn't work cross process. (Closed)

Created:
3 years, 7 months ago by Mircea Trofin
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[wasm] Ensure postMessage doesn't work cross process. Wasm module structured cloning should not work over process boundaries. BUG= Review-Url: https://codereview.chromium.org/2847063002 Cr-Commit-Position: refs/heads/master@{#468742} Committed: https://chromium.googlesource.com/chromium/src/+/b6567be47346a26d9e431c64d02e9176ae6a6308

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renames/fixes #

Patch Set 3 : Renames/fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/wasm/resources/remote_frame.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/wasm/wasm_remote_postMessage_test.https.html View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Mircea Trofin
Note that the error behavior currently being under specification isn't incorporated in this change. The ...
3 years, 7 months ago (2017-04-28 04:10:49 UTC) #3
domenic
This seems reasonable, although eventually we're going to need a comprehensive suite of tests similar ...
3 years, 7 months ago (2017-04-28 18:49:54 UTC) #8
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2847063002/diff/1/third_party/WebKit/LayoutTests/http/tests/wasm/resources/remote_frame.html File third_party/WebKit/LayoutTests/http/tests/wasm/resources/remote_frame.html (right): https://codereview.chromium.org/2847063002/diff/1/third_party/WebKit/LayoutTests/http/tests/wasm/resources/remote_frame.html#newcode5 third_party/WebKit/LayoutTests/http/tests/wasm/resources/remote_frame.html:5: if(!ret) ret = "didn't make it" nit. space after ...
3 years, 7 months ago (2017-05-02 09:15:12 UTC) #9
Mircea Trofin
ptal
3 years, 7 months ago (2017-05-02 19:08:00 UTC) #12
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-02 19:08:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847063002/40001
3 years, 7 months ago (2017-05-02 19:22:53 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 19:30:54 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6567be47346a26d9e431c64d02e...

Powered by Google App Engine
This is Rietveld 408576698