Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2847043002: Revert of Roll googletest to 1.8.0. (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
Reviewers:
rkc, Dirk Pranke, skobes, Nico, pwnall, agl
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll googletest to 1.8.0. (patchset #7 id:340001 of https://codereview.chromium.org/2779193002/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467833 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I1MzlmYTExMjNhMTllNjQ5OWY1ODU4MmRhNTVjYTVhZjlkZjk0YTQM Original issue's description: > Roll googletest to 1.8.0. > > GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same > googletest repository. In order to cope with this, the googletest > repository is now sourced at third_party/googletest. > > The file/directory layout of Google Test is not yet considered stable. > To minimize disruption while Google Test stabilizes, Chromium code will > be insulated from third_party/googletest. > > * testing/gtest/include/gtest/ and testing/gmock/include/gmock have > been populated with headers that forward into the appropriate locations of > third_party/googletest > > * testing/BUILD.gn has been populated with the targets > //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which > depend on the appropriate //third_party/googletest targets. > > All Chromium code should keep depending on the targets and headers > in testing/{gtest,gmock} for now. > > BUG=630705 > TBR=rkc > > Review-Url: https://codereview.chromium.org/2779193002 > Cr-Commit-Position: refs/heads/master@{#467833} > Committed: https://chromium.googlesource.com/chromium/src/+/b539fa1123a19e6499f58582da55ca5af9df94a4 TBR=thakis@chromium.org,dpranke@chromium.org,agl@chromium.org,rkc@chromium.org,skobes@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630705 Review-Url: https://codereview.chromium.org/2847043002 Cr-Commit-Position: refs/heads/master@{#467852} Committed: https://chromium.googlesource.com/chromium/src/+/ed7b62615d138c4d629540bab4a2757da5551134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -430 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +6 lines, -3 lines 0 comments Download
M base/gtest_prod_util.h View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/testing/gmock/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_endpoint_service_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D testing/gmock/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D testing/gmock/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D testing/gmock/include/gmock/gmock.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gmock/include/gmock/gmock-actions.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-function-mockers.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gmock/include/gmock/gmock-matchers.h View 1 chunk +0 lines, -10 lines 0 comments Download
A testing/gmock_custom/gmock/internal/custom/gmock-port.h View 1 chunk +27 lines, -0 lines 0 comments Download
D testing/gtest/BUILD.gn View 1 chunk +0 lines, -68 lines 0 comments Download
D testing/gtest/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D testing/gtest/include/gtest/gtest.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-death-test.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-message.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-param-test.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-spi.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest_prod.h View 1 chunk +0 lines, -10 lines 0 comments Download
M testing/gtest_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/gtest_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M testing/gtest_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/googletest/BUILD.gn View 1 chunk +0 lines, -150 lines 0 comments Download
D third_party/googletest/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/googletest/README.chromium View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/googletest/gmock_custom/gmock/internal/custom/gmock-port.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
findit-for-me
Created Revert of Roll googletest to 1.8.0.
3 years, 7 months ago (2017-04-28 02:31:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847043002/1
3 years, 7 months ago (2017-04-28 02:46:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-04-28 02:46:16 UTC) #5
pwnall
On 2017/04/28 02:46:16, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 7 months ago (2017-04-28 02:47:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847043002/1
3 years, 7 months ago (2017-04-28 02:48:29 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 02:49:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed7b62615d138c4d629540bab4a2...

Powered by Google App Engine
This is Rietveld 408576698