Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2847013003: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, jam, darin-cc_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2847013003 Cr-Commit-Position: refs/heads/master@{#468006} Committed: https://chromium.googlesource.com/chromium/src/+/4990bf6e0264a539cf76b09243dffc27e6546c52

Patch Set 1 #

Patch Set 2 : rev #

Patch Set 3 : rev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M chrome/browser/history/chrome_history_backend_client.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M components/history/content/browser/web_contents_top_sites_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/history/content/browser/web_contents_top_sites_observer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/history/core/browser/history_backend.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/history/ios/browser/web_state_top_sites_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/history/ios/browser/web_state_top_sites_observer.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-28 03:56:58 UTC) #10
sdefresne
lgtm and thank you for the cleanup.
3 years, 7 months ago (2017-04-28 10:14:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847013003/40001
3 years, 7 months ago (2017-04-28 15:22:26 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 15:29:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4990bf6e0264a539cf76b09243df...

Powered by Google App Engine
This is Rietveld 408576698