Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2847003007:
Add default PDF dpi setting (Closed)
DescriptionAdd default PDF dpi setting
Make sure save as PDF sets DPI to a nonzero value. Since we now check it
in Windows, if the job settings were previously invalid it will crash if
the printer does not reset them correctly.
BUG=None
Review-Url: https://codereview.chromium.org/2847003007
Cr-Commit-Position: refs/heads/master@{#468351}
Committed: https://chromium.googlesource.com/chromium/src/+/7993a7f17e118c7e7eeb5762aca56db699c768e5
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use kPointsPerInch #Messages
Total messages: 17 (12 generated)
Description was changed from ========== Add default PDF dpi setting Make sure save as PDF sets DPI to a nonzero value. Since we now check it in Windows, if the job settings were previously invalid it will crash if the printer does not reset them correctly. BUG=None ========== to ========== Add default PDF dpi setting Make sure save as PDF sets DPI to a nonzero value. Since we now check it in Windows, if the job settings were previously invalid it will crash if the printer does not reset them correctly. BUG=None ==========
rbpotter@chromium.org changed reviewers: + thestig@chromium.org
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2847003007/diff/1/printing/printing_context.cc File printing/printing_context.cc (right): https://codereview.chromium.org/2847003007/diff/1/printing/printing_context.c... printing/printing_context.cc:68: pdf_settings->SetInteger(kSettingDpiHorizontal, 72); Do we want to use kPointsPerInch here?
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
https://codereview.chromium.org/2847003007/diff/1/printing/printing_context.cc File printing/printing_context.cc (right): https://codereview.chromium.org/2847003007/diff/1/printing/printing_context.c... printing/printing_context.cc:68: pdf_settings->SetInteger(kSettingDpiHorizontal, 72); On 2017/04/29 01:29:58, Lei Zhang wrote: > Do we want to use kPointsPerInch here? Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2847003007/#ps20001 (title: "Use kPointsPerInch")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493656665284630,
"parent_rev": "4e981bd3206d558e19b9dd04ef9c83bd2ccb6b0f", "commit_rev":
"7993a7f17e118c7e7eeb5762aca56db699c768e5"}
Message was sent while issue was closed.
Description was changed from ========== Add default PDF dpi setting Make sure save as PDF sets DPI to a nonzero value. Since we now check it in Windows, if the job settings were previously invalid it will crash if the printer does not reset them correctly. BUG=None ========== to ========== Add default PDF dpi setting Make sure save as PDF sets DPI to a nonzero value. Since we now check it in Windows, if the job settings were previously invalid it will crash if the printer does not reset them correctly. BUG=None Review-Url: https://codereview.chromium.org/2847003007 Cr-Commit-Position: refs/heads/master@{#468351} Committed: https://chromium.googlesource.com/chromium/src/+/7993a7f17e118c7e7eeb5762aca5... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7993a7f17e118c7e7eeb5762aca5... |
