MD Settings: Fix cookie exceptions flex layout regression.

MD Settings: Fix cookie exceptions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846973002
Cr-Commit-Position: refs/heads/master@{#467827}
Committed: https://chromium.googlesource.com/chromium/src/+/d681cc9be589ff887ca6259e1872e36d75f2b932

[dpapad, 2017-04-27 21:48:38]

Description was changed from

==========
MD Settings: Fix cookies extensions flex layout regression.

BUG=715903
==========

to

==========
MD Settings: Fix cookies extensions flex layout regression.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-27 21:48:42]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:49:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-27 21:51:58]

Description was changed from

==========
MD Settings: Fix cookies extensions flex layout regression.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix cookies extensions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html, the UI broke and revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-27 21:52:28]

Description was changed from

==========
MD Settings: Fix cookies extensions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html, the UI broke and revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix cookies extensions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and revealed
the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-27 21:53:45]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2017-04-27 21:53:46]

Before/after screenshots at http://imgur.com/a/bNJYP.

[dpapad, 2017-04-27 21:54:08]

Description was changed from

==========
MD Settings: Fix cookies extensions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and revealed
the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix cookies extensions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-27 21:54:35]

Description was changed from

==========
MD Settings: Fix cookies extensions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix cookie exceptions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-04-27 21:57:26]

https://codereview.chromium.org/2846973002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_list.html (right):

https://codereview.chromium.org/2846973002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_list.html:66: <div
class="layout horizontal center flex"
I think "layout horizontal center flex" may be replaced with "start" and the
import of iron-flex-layout removed (if so yay to less code).

[dschuyler, 2017-04-27 22:20:54]

lgtm

https://codereview.chromium.org/2846973002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_list.html (right):

https://codereview.chromium.org/2846973002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_list.html:66: <div
class="layout horizontal center flex"
On 2017/04/27 21:57:26, dschuyler wrote:
> I think "layout horizontal center flex" may be replaced with "start" and the
> import of iron-flex-layout removed (if so yay to less code).

We just chatted about this and it's a bit more involved. Removing the need to
import the iron-flex-layout can be done later.

[dpapad, 2017-04-27 22:24:08]

On 2017/04/27 at 22:20:54, dschuyler wrote:
> lgtm
> 
>
https://codereview.chromium.org/2846973002/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/site_settings/site_list.html (right):
> 
>
https://codereview.chromium.org/2846973002/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/site_settings/site_list.html:66: <div
class="layout horizontal center flex"
> On 2017/04/27 21:57:26, dschuyler wrote:
> > I think "layout horizontal center flex" may be replaced with "start" and the
> > import of iron-flex-layout removed (if so yay to less code).
> 
> We just chatted about this and it's a bit more involved. Removing the need to
import the iron-flex-layout can be done later.

Thanks!

[dpapad, 2017-04-27 22:24:41]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-04-27 22:24:44]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:30:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:59:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493331884111580, "parent_rev":
"5523578be7767b76e2eff354c98a82dcd8f653b5", "commit_rev":
"d681cc9be589ff887ca6259e1872e36d75f2b932"}

[commit-bot: I haz the power, 2017-04-28 01:59:56]

Description was changed from

==========
MD Settings: Fix cookie exceptions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix cookie exceptions flex layout regression.

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846973002
Cr-Commit-Position: refs/heads/master@{#467827}
Committed:
https://chromium.googlesource.com/chromium/src/+/d681cc9be589ff887ca6259e1872...
==========

[commit-bot: I haz the power, 2017-04-28 01:59:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d681cc9be589ff887ca6259e1872...