Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2846963002:
Don't build sync_integration_tests by default for official builds. (Closed)
|
Created:
3 years, 7 months ago by Michael Moss Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't build sync_integration_tests by default for official builds.
I think this used to be built by the old Windows official builders, but
I have no idea if it was ever even used, and AFAICT, it hasn't ever been
built by the current (PGO) builders, and hasn't been missed. It seems we
don't really need it (especially not for the official continuous
builders, which appear to be the only ones that currently build the
"chrome_official_builder" target).
R=dimu@google.com, dpranke@google.com
Review-Url: https://codereview.chromium.org/2846963002
Cr-Commit-Position: refs/heads/master@{#467867}
Committed: https://chromium.googlesource.com/chromium/src/+/68c4ff049efc98e035445aefb940594a7cfeb054
Patch Set 1 #Messages
Total messages: 26 (11 generated)
lgtm
The CQ bit was checked by mmoss@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by mmoss@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/04/27 22:49:47, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Seriously? Is this because it was LGTM'd with @google instead of @chromium accounts?
Description was changed from ========== Don't build sync_integration_tests by default for official builds. I think this used to be built by the old Windows official builders, but I have no idea if it was ever even used, and AFAICT, it hasn't ever been built by the current (PGO) builders, and hasn't been missed. It seems we don't really need it (especially not for the official continuous builders, which appear to be the only ones that currently build the "chrome_official_builder" target). R=dimu@google.com, dpranke@google.com ========== to ========== Don't build sync_integration_tests by default for official builds. I think this used to be built by the old Windows official builders, but I have no idea if it was ever even used, and AFAICT, it hasn't ever been built by the current (PGO) builders, and hasn't been missed. It seems we don't really need it (especially not for the official continuous builders, which appear to be the only ones that currently build the "chrome_official_builder" target). R=dimu@google.com, dpranke@google.com ==========
mmoss@google.com changed reviewers: + dpranke@chromium.org
The CQ bit was checked by mmoss@google.com
On 2017/04/27 22:51:47, mmoss wrote: > On 2017/04/27 22:49:47, commit-bot: I haz the power wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started once the patch has received an L-G-T-M from a full > > committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > > full super star committer. > > Committers are members of the group "project-chromium-committers". > > Note that this has nothing to do with OWNERS files. > > Seriously? Is this because it was LGTM'd with @google instead of @chromium > accounts? Yeah, sigh.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm.
The CQ bit was checked by mmoss@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493333737436930, "parent_rev":
"7da9cf91983855bf2e5861dbe33d50fc9aca9df0", "commit_rev":
"68c4ff049efc98e035445aefb940594a7cfeb054"}
Message was sent while issue was closed.
Description was changed from ========== Don't build sync_integration_tests by default for official builds. I think this used to be built by the old Windows official builders, but I have no idea if it was ever even used, and AFAICT, it hasn't ever been built by the current (PGO) builders, and hasn't been missed. It seems we don't really need it (especially not for the official continuous builders, which appear to be the only ones that currently build the "chrome_official_builder" target). R=dimu@google.com, dpranke@google.com ========== to ========== Don't build sync_integration_tests by default for official builds. I think this used to be built by the old Windows official builders, but I have no idea if it was ever even used, and AFAICT, it hasn't ever been built by the current (PGO) builders, and hasn't been missed. It seems we don't really need it (especially not for the official continuous builders, which appear to be the only ones that currently build the "chrome_official_builder" target). R=dimu@google.com, dpranke@google.com Review-Url: https://codereview.chromium.org/2846963002 Cr-Commit-Position: refs/heads/master@{#467867} Committed: https://chromium.googlesource.com/chromium/src/+/68c4ff049efc98e035445aefb940... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/68c4ff049efc98e035445aefb940...
Message was sent while issue was closed.
lgtm |
