Use ScopedTaskEnvironment instead of MessageLoopForUI in remoting tests.

Use ScopedTaskEnvironment instead of MessageLoopForUI in remoting tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=garykac@chromium.org

Review-Url: https://codereview.chromium.org/2846943002
Cr-Commit-Position: refs/heads/master@{#468018}
Committed: https://chromium.googlesource.com/chromium/src/+/638b48e2f217dd8fe276e91906d7c3a6f6506eac

[fdoray, 2017-04-27 18:33:11]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-04-27 18:33:16]

gab@: PTAL

The change will then be TBRed to the owner.

[commit-bot: I haz the power, 2017-04-27 18:34:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 18:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 18:53:57]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[fdoray, 2017-04-27 19:13:24]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 19:13:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:34:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:34:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[fdoray, 2017-04-27 20:03:17]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 20:04:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:18:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-04-28 01:34:44]

lgtm w/ comment

https://codereview.chromium.org/2846943002/diff/40001/remoting/test/it2me_sta...
File remoting/test/it2me_standalone_host.h (right):

https://codereview.chromium.org/2846943002/diff/40001/remoting/test/it2me_sta...
remoting/test/it2me_standalone_host.h:46: base::test::ScopedTaskEnvironment
scoped_task_environment_;
ditto
https://codereview.chromium.org/2849603003/diff/60001/ui/aura/mus/os_exchange...

[fdoray, 2017-04-28 13:23:42]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 13:24:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-28 13:24:37]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-04-28 13:24:41]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-04-28 13:24:41]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2846943002/#ps60001
(title: "add-deps")

[commit-bot: I haz the power, 2017-04-28 13:24:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-28 13:25:26]

https://codereview.chromium.org/2846943002/diff/40001/remoting/test/it2me_sta...
File remoting/test/it2me_standalone_host.h (right):

https://codereview.chromium.org/2846943002/diff/40001/remoting/test/it2me_sta...
remoting/test/it2me_standalone_host.h:46: base::test::ScopedTaskEnvironment
scoped_task_environment_;
On 2017/04/28 01:34:44, gab wrote:
> ditto
>
https://codereview.chromium.org/2849603003/diff/60001/ui/aura/mus/os_exchange...

No. Compiler complains that there is no assignment operator.

[commit-bot: I haz the power, 2017-04-28 16:10:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493385881066990,
"parent_rev": "e17ef94d67dfe018efe33b4a6c95337ca193e388", "commit_rev":
"638b48e2f217dd8fe276e91906d7c3a6f6506eac"}

[commit-bot: I haz the power, 2017-04-28 16:10:58]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoopForUI in remoting tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=garykac@chromium.org
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoopForUI in remoting tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=garykac@chromium.org

Review-Url: https://codereview.chromium.org/2846943002
Cr-Commit-Position: refs/heads/master@{#468018}
Committed:
https://chromium.googlesource.com/chromium/src/+/638b48e2f217dd8fe276e91906d7...
==========

[commit-bot: I haz the power, 2017-04-28 16:11:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/638b48e2f217dd8fe276e91906d7...