chromeos: makes WindowManager not delete shell when connection to mus is lost

chromeos: makes WindowManager not delete shell when connection to mus is lost

Chrome also detects when the connection to mus is lost and further
chrome needs to control when the shell it shutdown, so adds the option
to set a callback that controls what should happen when connection to
mus is lost.

I think there is more that needs to happen, but this is a good start.

BUG=709593
TEST=covered by tests
R=jonross@chromium.org

Review-Url: https://codereview.chromium.org/2846893004
Cr-Commit-Position: refs/heads/master@{#468013}
Committed: https://chromium.googlesource.com/chromium/src/+/01c007bd982841a14c4a8279b019daa062471d4d

[sky, 2017-04-28 15:10:55]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 15:11:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jonross, 2017-04-28 15:15:24]

On 2017/04/28 15:10:52, sky wrote:

Yeah this is definitely a good start. LGTM

With this change, when you close chrome --mus with ctrl+c are you seeing any
errors from WindowTreeClient now?

[sky, 2017-04-28 15:17:41]

Sometimes, yes. I didn't have a chance to figure out who still has windows
open. I wanted to see if this at least helps browser_tests.

On Fri, Apr 28, 2017 at 8:15 AM, <jonross@chromium.org> wrote:

> On 2017/04/28 15:10:52, sky wrote:
>
> Yeah this is definitely a good start. LGTM
>
> With this change, when you close chrome --mus with ctrl+c are you seeing
> any
> errors from WindowTreeClient now?
>
> https://codereview.chromium.org/2846893004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2017-04-28 15:17:50]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-04-28 15:17:53]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:18:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jonross, 2017-04-28 15:20:04]

On 2017/04/28 15:18:03, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Good to know. I can take another look with this patch. A bunch of the currently
disabled tests were having WTC errors, so we can likely expand coverage after
this lands.

Thanks!

[commit-bot: I haz the power, 2017-04-28 15:48:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493392673319300, "parent_rev":
"52a0bdcdc8f43d3142ae7e4055a56aa2288d23b6", "commit_rev":
"01c007bd982841a14c4a8279b019daa062471d4d"}

[commit-bot: I haz the power, 2017-04-28 15:49:00]

Description was changed from

==========
chromeos: makes WindowManager not delete shell when connection to mus is lost

Chrome also detects when the connection to mus is lost and further
chrome needs to control when the shell it shutdown, so adds the option
to set a callback that controls what should happen when connection to
mus is lost.

I think there is more that needs to happen, but this is a good start.

BUG=709593
TEST=covered by tests
R=jonross@chromium.org
==========

to

==========
chromeos: makes WindowManager not delete shell when connection to mus is lost

Chrome also detects when the connection to mus is lost and further
chrome needs to control when the shell it shutdown, so adds the option
to set a callback that controls what should happen when connection to
mus is lost.

I think there is more that needs to happen, but this is a good start.

BUG=709593
TEST=covered by tests
R=jonross@chromium.org

Review-Url: https://codereview.chromium.org/2846893004
Cr-Commit-Position: refs/heads/master@{#468013}
Committed:
https://chromium.googlesource.com/chromium/src/+/01c007bd982841a14c4a8279b019...
==========

[commit-bot: I haz the power, 2017-04-28 15:49:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01c007bd982841a14c4a8279b019...