Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2846883005: Rollback instrumentation during analysis and validate resolved ASTs instead. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rollback instrumentation during analysis and validate resolved ASTs instead. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0fe854621764ca0d15e74e9f6b4e8db95af10096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -203 lines) Patch
M pkg/analyzer/analyzer.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 3 chunks +1 line, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart View 7 chunks +3 lines, -20 lines 0 comments Download
D pkg/analyzer/lib/src/fasta/uri_instrumentation.dart View 1 chunk +0 lines, -113 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 7 chunks +4 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 3 chunks +182 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/int_upwards_local.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/int_upwards_local.dart.dartk.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/int_upwards_local.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/int_upwards_local.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/int_upwards_local.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_constructor_from_arguments.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/local_reference_upwards_local.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/local_reference_upwards_local.dart.dartk.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_reference_upwards_local.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_reference_upwards_local.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_reference_upwards_local.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/toplevel_inference_toplevel_var.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/toplevel_inference_toplevel_var.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/toplevel_inference_toplevel_var.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/toplevel_inference_toplevel_var.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_simple.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_simple.dart.dartk.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_simple.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_simple.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_simple.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart.dartk.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 7 months ago (2017-04-27 17:17:28 UTC) #1
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-04-27 17:20:57 UTC) #2
Paul Berry
lgtm
3 years, 7 months ago (2017-04-27 17:26:49 UTC) #3
scheglov
3 years, 7 months ago (2017-04-27 17:30:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0fe854621764ca0d15e74e9f6b4e8db95af10096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698