Rollback instrumentation during analysis and validate resolved ASTs instead.

pkg/analyzer/lib/src/dart/analysis/driver.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:typed_data';
 
 import 'package:analyzer/context/context_root.dart';
 import 'package:analyzer/context/declared_variables.dart';
@@ skipping 12 matching lines @@
 import 'package:analyzer/src/dart/analysis/library_context.dart';
 import 'package:analyzer/src/dart/analysis/search.dart';
 import 'package:analyzer/src/dart/analysis/status.dart';
 import 'package:analyzer/src/dart/analysis/top_level_declaration.dart';
 import 'package:analyzer/src/generated/engine.dart'
     show AnalysisContext, AnalysisEngine, AnalysisOptions;
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/lint/registry.dart' as linter;
 import 'package:analyzer/src/summary/api_signature.dart';
 import 'package:analyzer/src/summary/format.dart';
-import 'package:front_end/src/base/instrumentation.dart' as fasta;
 import 'package:analyzer/src/summary/idl.dart';
 import 'package:analyzer/src/summary/package_bundle_reader.dart';
 import 'package:meta/meta.dart';
 
 /**
  * This class computes [AnalysisResult]s for Dart files.
  *
  * Let the set of "explicitly analyzed files" denote the set of paths that have
  * been passed to [addFile] but not subsequently passed to [removeFile]. Let
  * the "current analysis results" denote the map from the set of explicitly
@@ skipping 970 matching lines @@
       try {
         LibraryContext libraryContext = _createLibraryContext(library);
         try {
           _testView.numOfAnalyzedLibraries++;
           LibraryAnalyzer analyzer = new LibraryAnalyzer(
               analysisOptions,
               declaredVariables,
               sourceFactory,
               _fsState,
               libraryContext.store,
-              library,
-              _testView.instrumentation);
+              library);
           Map<FileState, UnitAnalysisResult> results = analyzer.analyze();
 
           List<int> bytes;
           CompilationUnit resolvedUnit;
           for (FileState unitFile in results.keys) {
             UnitAnalysisResult unitResult = results[unitFile];
             List<int> unitBytes =
                 _serializeResolvedUnit(unitResult.unit, unitResult.errors);
             String unitSignature = _getResolvedUnitSignature(library, unitFile);
             String unitKey = _getResolvedUnitKey(unitSignature);
@@ skipping 522 matching lines @@
 }
 
 @visibleForTesting
 class AnalysisDriverTestView {
   final AnalysisDriver driver;
 
   int numOfCreatedLibraryContexts = 0;
 
   int numOfAnalyzedLibraries = 0;
 
-  fasta.Instrumentation instrumentation;
-
   AnalysisDriverTestView(this.driver);
 
   FileTracker get fileTracker => driver._fileTracker;
 
   Map<String, AnalysisResult> get priorityResults => driver._priorityResults;
 
   SummaryDataStore getSummaryStore(String libraryPath) {
     FileState library = driver.fsState.getFileForPath(libraryPath);
     LibraryContext libraryContext = driver._createLibraryContext(library);
     try {
@@ skipping 525 matching lines @@
           libraryDeclarations.add(new TopLevelDeclarationInSource(
               file.source, declaration, isExported));
         }
       }
     }
 
     // We're not done yet.
     return false;
   }
 }